diff options
| author |  kim <89579420+NyaaaWhatsUpDoc@users.noreply.github.com> | 2024-08-02 12:15:11 +0000 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2024-08-02 13:15:11 +0100 |
| commit | 0f734a24100383171a866fccc194dea578141d74 (patch) | |
| tree | a2cfdebeb1098ef39a8b2907a0933ac7f18a3ca3 /internal/processing/status/pin.go | |
| parent | [chore] add back exif-terminator and use only for jpeg,png,webp (#3161) (diff) | |
| download | gotosocial-0f734a24100383171a866fccc194dea578141d74.tar.xz | |
[chore] move PopulateAccountStats() nil check often performed into function itself (#3158)
* move PopulateAccountStats() nil check often performed into function itself
* fix test to take in mind we don't repopulate account stats if not-nil
Diffstat (limited to 'internal/processing/status/pin.go')
| -rw-r--r-- | internal/processing/status/pin.go | 16 |
1 files changed, 6 insertions, 10 deletions
diff --git a/internal/processing/status/pin.go b/internal/processing/status/pin.go index c4a6fc3b8..3f8435e52 100644 --- a/internal/processing/status/pin.go +++ b/internal/processing/status/pin.go @@ -92,11 +92,9 @@ func (p *Processor) PinCreate(ctx context.Context, requestingAccount *gtsmodel.A } // Ensure account stats populated. - if requestingAccount.Stats == nil { - if err := p.state.DB.PopulateAccountStats(ctx, requestingAccount); err != nil { - err = gtserror.Newf("db error getting account stats: %w", err) - return nil, gtserror.NewErrorInternalError(err) - } + if err := p.state.DB.PopulateAccountStats(ctx, requestingAccount); err != nil { + err = gtserror.Newf("db error getting account stats: %w", err) + return nil, gtserror.NewErrorInternalError(err) } pinnedCount := *requestingAccount.Stats.StatusesPinnedCount @@ -157,11 +155,9 @@ func (p *Processor) PinRemove(ctx context.Context, requestingAccount *gtsmodel.A } // Ensure account stats populated. - if requestingAccount.Stats == nil { - if err := p.state.DB.PopulateAccountStats(ctx, requestingAccount); err != nil { - err = gtserror.Newf("db error getting account stats: %w", err) - return nil, gtserror.NewErrorInternalError(err) - } + if err := p.state.DB.PopulateAccountStats(ctx, requestingAccount); err != nil { + err = gtserror.Newf("db error getting account stats: %w", err) + return nil, gtserror.NewErrorInternalError(err) } targetStatus.PinnedAt = time.Time{} |