From 0f734a24100383171a866fccc194dea578141d74 Mon Sep 17 00:00:00 2001 From: kim <89579420+NyaaaWhatsUpDoc@users.noreply.github.com> Date: Fri, 2 Aug 2024 12:15:11 +0000 Subject: [chore] move PopulateAccountStats() nil check often performed into function itself (#3158) * move PopulateAccountStats() nil check often performed into function itself * fix test to take in mind we don't repopulate account stats if not-nil --- internal/processing/status/pin.go | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) (limited to 'internal/processing/status/pin.go') diff --git a/internal/processing/status/pin.go b/internal/processing/status/pin.go index c4a6fc3b8..3f8435e52 100644 --- a/internal/processing/status/pin.go +++ b/internal/processing/status/pin.go @@ -92,11 +92,9 @@ func (p *Processor) PinCreate(ctx context.Context, requestingAccount *gtsmodel.A } // Ensure account stats populated. - if requestingAccount.Stats == nil { - if err := p.state.DB.PopulateAccountStats(ctx, requestingAccount); err != nil { - err = gtserror.Newf("db error getting account stats: %w", err) - return nil, gtserror.NewErrorInternalError(err) - } + if err := p.state.DB.PopulateAccountStats(ctx, requestingAccount); err != nil { + err = gtserror.Newf("db error getting account stats: %w", err) + return nil, gtserror.NewErrorInternalError(err) } pinnedCount := *requestingAccount.Stats.StatusesPinnedCount @@ -157,11 +155,9 @@ func (p *Processor) PinRemove(ctx context.Context, requestingAccount *gtsmodel.A } // Ensure account stats populated. - if requestingAccount.Stats == nil { - if err := p.state.DB.PopulateAccountStats(ctx, requestingAccount); err != nil { - err = gtserror.Newf("db error getting account stats: %w", err) - return nil, gtserror.NewErrorInternalError(err) - } + if err := p.state.DB.PopulateAccountStats(ctx, requestingAccount); err != nil { + err = gtserror.Newf("db error getting account stats: %w", err) + return nil, gtserror.NewErrorInternalError(err) } targetStatus.PinnedAt = time.Time{} -- cgit v1.2.3