1 files changed, 9 insertions, 24 deletions
diff --git a/internal/federation/federatingdb/followers.go b/internal/federation/federatingdb/followers.go
index d9a359227..d829a304c 100644
--- a/internal/federation/federatingdb/followers.go
+++ b/internal/federation/federatingdb/followers.go
@@ -22,9 +22,7 @@ import (
 	"fmt"
 	"net/url"
 
-	"codeberg.org/gruf/go-kv"
 	"github.com/superseriousbusiness/activity/streams/vocab"
-	"github.com/superseriousbusiness/gotosocial/internal/db"
 	"github.com/superseriousbusiness/gotosocial/internal/log"
 )
 
@@ -35,43 +33,30 @@ import (
 //
 // The library makes this call only after acquiring a lock first.
 func (f *federatingDB) Followers(ctx context.Context, actorIRI *url.URL) (followers vocab.ActivityStreamsCollection, err error) {
-	l := log.WithContext(ctx).
-		WithFields(kv.Fields{
-			{"id", actorIRI},
-		}...)
-	l.Debug("entering Followers")
-
 	acct, err := f.getAccountForIRI(ctx, actorIRI)
 	if err != nil {
 		return nil, err
 	}
 
-	acctFollowers, err := f.state.DB.GetAccountFollowedBy(ctx, acct.ID, false)
+	follows, err := f.state.DB.GetFollows(ctx, "", acct.ID)
 	if err != nil {
 		return nil, fmt.Errorf("Followers: db error getting followers for account id %s: %s", acct.ID, err)
 	}
 
-	iris := []*url.URL{}
-	for _, follow := range acctFollowers {
+	iris := make([]*url.URL, 0, len(follows))
+	for _, follow := range follows {
 		if follow.Account == nil {
-			a, err := f.state.DB.GetAccountByID(ctx, follow.AccountID)
-			if err != nil {
-				errWrapped := fmt.Errorf("Followers: db error getting account id %s: %s", follow.AccountID, err)
-				if err == db.ErrNoEntries {
-					// no entry for this account id so it's probably been deleted and we haven't caught up yet
-					l.Error(errWrapped)
-					continue
-				} else {
-					// proper error
-					return nil, errWrapped
-				}
-			}
-			follow.Account = a
+			// Follow account no longer exists,
+			// for some reason. Skip this one.
+			log.WithContext(ctx).WithField("follow", follow).Warnf("follow missing account %s", follow.AccountID)
+			continue
 		}
+
 		u, err := url.Parse(follow.Account.URI)
 		if err != nil {
 			return nil, err
 		}
+
 		iris = append(iris, u)
 	}