[chore] Refactor HTML templates and CSS (#2480)

* [chore] Refactor HTML templates and CSS

* eslint

* ignore "Local"

* rss tests

* fiddle with OG just a tiny bit

* dick around with polls a bit more so SR stops saying "clickable"

* remove break

* oh lord

* don't lazy load avatar

* fix ogmeta tests

* clean up some cruft

* catch remaining calls to c.HTML

* fix error rendering + stack overflow in tag

* allow templating attributes

* fix indent

* set aria-hidden on status complementary content, since it's already present in the label anyway

* tidy up templating calls a little

* try to make styling a bit more consistent + readable

* fix up some remaining CSS issues

* fix up reports

1 files changed, 28 insertions, 31 deletions

diff --git a/web/template/finalize.tmpl b/web/template/finalize.tmpl
index e0d880db7..56ab677e5 100644
--- a/web/template/finalize.tmpl
+++ b/web/template/finalize.tmpl
@@ -17,34 +17,31 @@
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */ -}}
 
-{{ template "header.tmpl" .}}
-    <main>
-        <form action="/oauth/finalize" method="POST">
-            <h1>Hi {{.name}}!</h1>
-            <p>
-              You are about to sign-up to {{ .instance.Title }} (<code>{{ .instance.URI }}</code>)
-              <br>
-              To ensure the best experience for you, we need you to provide some additional details.
-            </p>
-            {{if .error}}
-              <section class="error">
-                <span>❌</span> <pre>{{.error}}</pre>
-              </section>
-            {{end}}
-            <div class="callout">
-              <p class="callout-title">Important</p>
-              <p>Due to the way the ActivityPub standard works, you <strong>cannot</strong> change your username after it has been set.</p>
-            </div>
-            <div class="labelinput">
-                <label for="username">Username <small>(must contain only lowercase letters, numbers, and underscores)</small></label>
-                <input type="text"
-                       class="form-control"
-                       name="username"
-                       required
-                       placeholder="Please enter your desired username" value="{{ .preferredUsername }}">
-            </div>
-            <input type="hidden" name="name" value="{{ .name }}">
-            <button type="submit" style="width: 100%; margin-top: 1rem;" class="btn btn-success">Submit</button>
-        </form>
-    </main>
-{{ template "footer.tmpl" .}}
+{{- with . }}
+<main>
+    <form action="/oauth/finalize" method="POST">
+        <h1>Hi {{ .name -}}!</h1>
+        <p>
+            You are about to sign-up to {{ .instance.Title -}}.
+            To ensure the best experience for you, we need you to provide some additional details.
+        </p>
+        <div class="callout">
+            <p class="callout-title">Important</p>
+            <p>Due to the way the ActivityPub standard works, you <strong>cannot</strong> change your username after it has been set.</p>
+        </div>
+        <div class="labelinput">
+            <label for="username">Username <small>(must contain only lowercase letters, numbers, and underscores)</small></label>
+            <input 
+                type="text"
+                class="form-control"
+                name="username"
+                required
+                placeholder="Please enter your desired username"
+                value="{{- .preferredUsername -}}"
+            >
+        </div>
+        <input type="hidden" name="name" value="{{- .name -}}">
+        <button type="submit" style="width: 100%; margin-top: 1rem;" class="btn btn-success">Submit</button>
+    </form>
+</main>
+{{- end }}
\ No newline at end of file