[bugfix] Fix images not being processed correctly sometimes (#437)

* bump exif-terminator to latest version

* add and test giant turnip from turnip.farm

* don't error if content property is nil

13 files changed, 55 insertions, 5 deletions

diff --git a/vendor/github.com/superseriousbusiness/exif-terminator/jpeg.go b/vendor/github.com/superseriousbusiness/exif-terminator/jpeg.go
index 224a9b646..e3da53d54 100644
--- a/vendor/github.com/superseriousbusiness/exif-terminator/jpeg.go
+++ b/vendor/github.com/superseriousbusiness/exif-terminator/jpeg.go
@@ -23,7 +23,7 @@ import (
 	"fmt"
 	"io"
 
-	jpegstructure "github.com/dsoprea/go-jpeg-image-structure/v2"
+	jpegstructure "github.com/superseriousbusiness/go-jpeg-image-structure/v2"
 )
 
 var markerLen = map[byte]int{
diff --git a/vendor/github.com/superseriousbusiness/exif-terminator/logger.go b/vendor/github.com/superseriousbusiness/exif-terminator/logger.go
new file mode 100644
index 000000000..e607c55dd
--- /dev/null
+++ b/vendor/github.com/superseriousbusiness/exif-terminator/logger.go
@@ -0,0 +1,47 @@
+/*
+   exif-terminator
+   Copyright (C) 2022 SuperSeriousBusiness admin@gotosocial.org
+
+   This program is free software: you can redistribute it and/or modify
+   it under the terms of the GNU Affero General Public License as published by
+   the Free Software Foundation, either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU Affero General Public License for more details.
+
+   You should have received a copy of the GNU Affero General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
+*/
+
+package terminator
+
+import "fmt"
+
+var logger ErrorLogger
+
+func init() {
+	logger = &defaultErrorLogger{}
+}
+
+// ErrorLogger denotes a generic error logging function.
+type ErrorLogger interface {
+	Error(args ...interface{})
+}
+
+type defaultErrorLogger struct{}
+
+func (d *defaultErrorLogger) Error(args ...interface{}) {
+	fmt.Println(args...)
+}
+
+// SetErrorLogger allows a user of the exif-terminator library
+// to set the logger that will be used for error logging.
+//
+// If it is not set, the default error logger will be used, which
+// just prints errors to stdout.
+func SetErrorLogger(errorLogger ErrorLogger) {
+	logger = errorLogger
+}
diff --git a/vendor/github.com/superseriousbusiness/exif-terminator/terminator.go b/vendor/github.com/superseriousbusiness/exif-terminator/terminator.go
index b6225f6dc..36f2d8b3a 100644
--- a/vendor/github.com/superseriousbusiness/exif-terminator/terminator.go
+++ b/vendor/github.com/superseriousbusiness/exif-terminator/terminator.go
@@ -25,7 +25,7 @@ import (
 	"fmt"
 	"io"
 
-	jpegstructure "github.com/dsoprea/go-jpeg-image-structure/v2"
+	jpegstructure "github.com/superseriousbusiness/go-jpeg-image-structure/v2"
 	pngstructure "github.com/dsoprea/go-png-image-structure/v2"
 )
 
@@ -109,8 +109,11 @@ func scanAndClose(scanner *bufio.Scanner, writer io.WriteCloser) {
 	// until the pipeReader starts being read by the caller, which
 	// is why we do this asynchronously
 	go func() {
+		defer writer.Close()
 		for scanner.Scan() {
 		}
-		writer.Close()
+		if scanner.Err() != nil {
+			logger.Error(scanner.Err())
+		}
 	}()
 }
diff --git a/vendor/github.com/dsoprea/go-jpeg-image-structure/v2/.MODULE_ROOT b/vendor/github.com/superseriousbusiness/go-jpeg-image-structure/v2/.MODULE_ROOT
index e69de29bb..e69de29bb 100644
--- a/vendor/github.com/dsoprea/go-jpeg-image-structure/v2/.MODULE_ROOT
+++ b/vendor/github.com/superseriousbusiness/go-jpeg-image-structure/v2/.MODULE_ROOT
diff --git a/vendor/github.com/dsoprea/go-jpeg-image-structure/v2/LICENSE b/vendor/github.com/superseriousbusiness/go-jpeg-image-structure/v2/LICENSE
index 163291ed6..163291ed6 100644
--- a/vendor/github.com/dsoprea/go-jpeg-image-structure/v2/LICENSE
+++ b/vendor/github.com/superseriousbusiness/go-jpeg-image-structure/v2/LICENSE
diff --git a/vendor/github.com/dsoprea/go-jpeg-image-structure/v2/README.md b/vendor/github.com/superseriousbusiness/go-jpeg-image-structure/v2/README.md
index bf60ef504..bf60ef504 100644
--- a/vendor/github.com/dsoprea/go-jpeg-image-structure/v2/README.md
+++ b/vendor/github.com/superseriousbusiness/go-jpeg-image-structure/v2/README.md
diff --git a/vendor/github.com/dsoprea/go-jpeg-image-structure/v2/markers.go b/vendor/github.com/superseriousbusiness/go-jpeg-image-structure/v2/markers.go
index a12171bd8..a12171bd8 100644
--- a/vendor/github.com/dsoprea/go-jpeg-image-structure/v2/markers.go
+++ b/vendor/github.com/superseriousbusiness/go-jpeg-image-structure/v2/markers.go
diff --git a/vendor/github.com/dsoprea/go-jpeg-image-structure/v2/media_parser.go b/vendor/github.com/superseriousbusiness/go-jpeg-image-structure/v2/media_parser.go
index e6fc60bc4..e6fc60bc4 100644
--- a/vendor/github.com/dsoprea/go-jpeg-image-structure/v2/media_parser.go
+++ b/vendor/github.com/superseriousbusiness/go-jpeg-image-structure/v2/media_parser.go
diff --git a/vendor/github.com/dsoprea/go-jpeg-image-structure/v2/segment.go b/vendor/github.com/superseriousbusiness/go-jpeg-image-structure/v2/segment.go
index 6b433bf1f..6b433bf1f 100644
--- a/vendor/github.com/dsoprea/go-jpeg-image-structure/v2/segment.go
+++ b/vendor/github.com/superseriousbusiness/go-jpeg-image-structure/v2/segment.go
diff --git a/vendor/github.com/dsoprea/go-jpeg-image-structure/v2/segment_list.go b/vendor/github.com/superseriousbusiness/go-jpeg-image-structure/v2/segment_list.go
index b4f4d5810..b4f4d5810 100644
--- a/vendor/github.com/dsoprea/go-jpeg-image-structure/v2/segment_list.go
+++ b/vendor/github.com/superseriousbusiness/go-jpeg-image-structure/v2/segment_list.go
diff --git a/vendor/github.com/dsoprea/go-jpeg-image-structure/v2/splitter.go b/vendor/github.com/superseriousbusiness/go-jpeg-image-structure/v2/splitter.go
index 8e9c7c020..1856beddf 100644
--- a/vendor/github.com/dsoprea/go-jpeg-image-structure/v2/splitter.go
+++ b/vendor/github.com/superseriousbusiness/go-jpeg-image-structure/v2/splitter.go
@@ -232,8 +232,8 @@ func (js *JpegSplitter) readSegment(data []byte) (count int, err error) {
 		err = binary.Read(b, binary.BigEndian, &l)
 		log.PanicIf(err)
 
-		if l <= 2 {
-			log.Panicf("length of size read for non-special marker (%02x) is unexpectedly not more than two.", markerId)
+		if l < 2 {
+			log.Panicf("length of size read for non-special marker (%02x) is unexpectedly less than two.", markerId)
 		}
 
 		// (l includes the bytes of the length itself.)
diff --git a/vendor/github.com/dsoprea/go-jpeg-image-structure/v2/testing_common.go b/vendor/github.com/superseriousbusiness/go-jpeg-image-structure/v2/testing_common.go
index e7169c2f0..e7169c2f0 100644
--- a/vendor/github.com/dsoprea/go-jpeg-image-structure/v2/testing_common.go
+++ b/vendor/github.com/superseriousbusiness/go-jpeg-image-structure/v2/testing_common.go
diff --git a/vendor/github.com/dsoprea/go-jpeg-image-structure/v2/utility.go b/vendor/github.com/superseriousbusiness/go-jpeg-image-structure/v2/utility.go
index 1c618ba6d..1c618ba6d 100644
--- a/vendor/github.com/dsoprea/go-jpeg-image-structure/v2/utility.go
+++ b/vendor/github.com/superseriousbusiness/go-jpeg-image-structure/v2/utility.go