Implement Cobra CLI tooling, Viper config tooling (#336)

* start pulling out + replacing urfave and config

* replace many many instances of config

* move more stuff => viper

* properly remove urfave

* move some flags to root command

* add testrig commands to root

* alias config file keys

* start adding cli parsing tests

* reorder viper init

* remove config path alias

* fmt

* change config file keys to non-nested

* we're more or less in business now

* tidy up the common func

* go fmt

* get tests passing again

* add note about the cliparsing tests

* reorganize

* update docs with changes

* structure cmd dir better

* rename + move some files around

* fix dangling comma

1 files changed, 0 insertions, 94 deletions

diff --git a/vendor/github.com/urfave/cli/v2/parse.go b/vendor/github.com/urfave/cli/v2/parse.go
deleted file mode 100644
index 7df17296a..000000000
--- a/vendor/github.com/urfave/cli/v2/parse.go
+++ /dev/null
@@ -1,94 +0,0 @@
-package cli
-
-import (
-	"flag"
-	"strings"
-)
-
-type iterativeParser interface {
-	newFlagSet() (*flag.FlagSet, error)
-	useShortOptionHandling() bool
-}
-
-// To enable short-option handling (e.g., "-it" vs "-i -t") we have to
-// iteratively catch parsing errors. This way we achieve LR parsing without
-// transforming any arguments. Otherwise, there is no way we can discriminate
-// combined short options from common arguments that should be left untouched.
-// Pass `shellComplete` to continue parsing options on failure during shell
-// completion when, the user-supplied options may be incomplete.
-func parseIter(set *flag.FlagSet, ip iterativeParser, args []string, shellComplete bool) error {
-	for {
-		err := set.Parse(args)
-		if !ip.useShortOptionHandling() || err == nil {
-			if shellComplete {
-				return nil
-			}
-			return err
-		}
-
-		errStr := err.Error()
-		trimmed := strings.TrimPrefix(errStr, "flag provided but not defined: -")
-		if errStr == trimmed {
-			return err
-		}
-
-		// regenerate the initial args with the split short opts
-		argsWereSplit := false
-		for i, arg := range args {
-			// skip args that are not part of the error message
-			if name := strings.TrimLeft(arg, "-"); name != trimmed {
-				continue
-			}
-
-			// if we can't split, the error was accurate
-			shortOpts := splitShortOptions(set, arg)
-			if len(shortOpts) == 1 {
-				return err
-			}
-
-			// swap current argument with the split version
-			args = append(args[:i], append(shortOpts, args[i+1:]...)...)
-			argsWereSplit = true
-			break
-		}
-
-		// This should be an impossible to reach code path, but in case the arg
-		// splitting failed to happen, this will prevent infinite loops
-		if !argsWereSplit {
-			return err
-		}
-
-		// Since custom parsing failed, replace the flag set before retrying
-		newSet, err := ip.newFlagSet()
-		if err != nil {
-			return err
-		}
-		*set = *newSet
-	}
-}
-
-func splitShortOptions(set *flag.FlagSet, arg string) []string {
-	shortFlagsExist := func(s string) bool {
-		for _, c := range s[1:] {
-			if f := set.Lookup(string(c)); f == nil {
-				return false
-			}
-		}
-		return true
-	}
-
-	if !isSplittable(arg) || !shortFlagsExist(arg) {
-		return []string{arg}
-	}
-
-	separated := make([]string, 0, len(arg)-1)
-	for _, flagChar := range arg[1:] {
-		separated = append(separated, "-"+string(flagChar))
-	}
-
-	return separated
-}
-
-func isSplittable(flagArg string) bool {
-	return strings.HasPrefix(flagArg, "-") && !strings.HasPrefix(flagArg, "--") && len(flagArg) > 2
-}