[performance] media processing improvements (#1288)

* media processor consolidation and reformatting, reduce amount of required syscalls

Signed-off-by: kim <grufwub@gmail.com>

* update go-store library, stream jpeg/png encoding + use buffer pools, improved media processing AlreadyExists error handling

Signed-off-by: kim <grufwub@gmail.com>

* fix duration not being set, fix mp4 test expecting error

Signed-off-by: kim <grufwub@gmail.com>

* fix test expecting media files with different extension

Signed-off-by: kim <grufwub@gmail.com>

* remove unused code

Signed-off-by: kim <grufwub@gmail.com>

* fix expected storage paths in tests, update expected test thumbnails

Signed-off-by: kim <grufwub@gmail.com>

* remove dead code

Signed-off-by: kim <grufwub@gmail.com>

* fix cached presigned s3 url fetching

Signed-off-by: kim <grufwub@gmail.com>

* fix tests

Signed-off-by: kim <grufwub@gmail.com>

* fix test models

Signed-off-by: kim <grufwub@gmail.com>

* update media processing to use sync.Once{} for concurrency protection

Signed-off-by: kim <grufwub@gmail.com>

* shutup linter

Signed-off-by: kim <grufwub@gmail.com>

* fix passing in KVStore GetStream() as stream to PutStream()

Signed-off-by: kim <grufwub@gmail.com>

* fix unlocks of storage keys

Signed-off-by: kim <grufwub@gmail.com>

* whoops, return the error...

Signed-off-by: kim <grufwub@gmail.com>

* pour one out for tobi's code <3

Signed-off-by: kim <grufwub@gmail.com>

* add back the byte slurping code

Signed-off-by: kim <grufwub@gmail.com>

* check for both ErrUnexpectedEOF and EOF

Signed-off-by: kim <grufwub@gmail.com>

* add back links to file format header information

Signed-off-by: kim <grufwub@gmail.com>

Signed-off-by: kim <grufwub@gmail.com>

1 files changed, 14 insertions, 79 deletions

diff --git a/vendor/codeberg.org/gruf/go-store/v2/util/io.go b/vendor/codeberg.org/gruf/go-store/v2/util/io.go
index 3d62e8be6..c5135084a 100644
--- a/vendor/codeberg.org/gruf/go-store/v2/util/io.go
+++ b/vendor/codeberg.org/gruf/go-store/v2/util/io.go
@@ -5,102 +5,37 @@ import (
 	"io"
 )
 
-// ReaderSize ...
+// ReaderSize defines a reader of known size in bytes.
 type ReaderSize interface {
 	io.Reader
-
-	// Size ...
 	Size() int64
 }
 
-// ByteReaderSize ...
+// ByteReaderSize implements ReaderSize for an in-memory byte-slice.
 type ByteReaderSize struct {
-	bytes.Reader
+	br bytes.Reader
 	sz int64
 }
 
-// NewByteReaderSize ...
+// NewByteReaderSize returns a new ByteReaderSize instance reset to slice b.
 func NewByteReaderSize(b []byte) *ByteReaderSize {
-	rs := ByteReaderSize{}
+	rs := new(ByteReaderSize)
 	rs.Reset(b)
-	return &rs
+	return rs
+}
+
+// Read implements io.Reader.
+func (rs *ByteReaderSize) Read(b []byte) (int, error) {
+	return rs.br.Read(b)
 }
 
-// Size implements ReaderSize.Size().
-func (rs ByteReaderSize) Size() int64 {
+// Size implements ReaderSize.
+func (rs *ByteReaderSize) Size() int64 {
 	return rs.sz
 }
 
 // Reset resets the ReaderSize to be reading from b.
 func (rs *ByteReaderSize) Reset(b []byte) {
-	rs.Reader.Reset(b)
+	rs.br.Reset(b)
 	rs.sz = int64(len(b))
 }
-
-// NopReadCloser turns a supplied io.Reader into io.ReadCloser with a nop Close() implementation.
-func NopReadCloser(r io.Reader) io.ReadCloser {
-	return &nopReadCloser{r}
-}
-
-// NopWriteCloser turns a supplied io.Writer into io.WriteCloser with a nop Close() implementation.
-func NopWriteCloser(w io.Writer) io.WriteCloser {
-	return &nopWriteCloser{w}
-}
-
-// ReadCloserWithCallback adds a customizable callback to be called upon Close() of a supplied io.ReadCloser.
-// Note that the callback will never be called more than once, after execution this will remove the func reference.
-func ReadCloserWithCallback(rc io.ReadCloser, cb func()) io.ReadCloser {
-	return &callbackReadCloser{
-		ReadCloser: rc,
-		callback:   cb,
-	}
-}
-
-// WriteCloserWithCallback adds a customizable callback to be called upon Close() of a supplied io.WriteCloser.
-// Note that the callback will never be called more than once, after execution this will remove the func reference.
-func WriteCloserWithCallback(wc io.WriteCloser, cb func()) io.WriteCloser {
-	return &callbackWriteCloser{
-		WriteCloser: wc,
-		callback:    cb,
-	}
-}
-
-// nopReadCloser turns an io.Reader -> io.ReadCloser with a nop Close().
-type nopReadCloser struct{ io.Reader }
-
-func (r *nopReadCloser) Close() error { return nil }
-
-// nopWriteCloser turns an io.Writer -> io.WriteCloser with a nop Close().
-type nopWriteCloser struct{ io.Writer }
-
-func (w nopWriteCloser) Close() error { return nil }
-
-// callbackReadCloser allows adding our own custom callback to an io.ReadCloser.
-type callbackReadCloser struct {
-	io.ReadCloser
-	callback func()
-}
-
-func (c *callbackReadCloser) Close() error {
-	if c.callback != nil {
-		cb := c.callback
-		c.callback = nil
-		defer cb()
-	}
-	return c.ReadCloser.Close()
-}
-
-// callbackWriteCloser allows adding our own custom callback to an io.WriteCloser.
-type callbackWriteCloser struct {
-	io.WriteCloser
-	callback func()
-}
-
-func (c *callbackWriteCloser) Close() error {
-	if c.callback != nil {
-		cb := c.callback
-		c.callback = nil
-		defer cb()
-	}
-	return c.WriteCloser.Close()
-}