[chore] The Big Middleware and API Refactor (tm) (#1250)

* interim commit: start refactoring middlewares into package under router

* another interim commit, this is becoming a big job

* another fucking massive interim commit

* refactor bookmarks to new style

* ambassador, wiz zeze commits you are spoiling uz

* she compiles, we're getting there

* we're just normal men; we're just innocent men

* apiutil

* whoopsie

* i'm glad noone reads commit msgs haha :blob_sweat:

* use that weirdo go-bytesize library for maxMultipartMemory

* fix media module paths

1 files changed, 45 insertions, 56 deletions

diff --git a/internal/web/web.go b/internal/web/web.go
index b9e0a63ff..f263c4655 100644
--- a/internal/web/web.go
+++ b/internal/web/web.go
@@ -19,28 +19,30 @@
 package web
 
 import (
-	"errors"
 	"net/http"
+	"path/filepath"
 
 	"codeberg.org/gruf/go-cache/v3"
 	"github.com/gin-gonic/gin"
-	"github.com/superseriousbusiness/gotosocial/internal/api"
-	"github.com/superseriousbusiness/gotosocial/internal/gtserror"
+	"github.com/superseriousbusiness/gotosocial/internal/config"
+	"github.com/superseriousbusiness/gotosocial/internal/log"
 	"github.com/superseriousbusiness/gotosocial/internal/processing"
 	"github.com/superseriousbusiness/gotosocial/internal/router"
 	"github.com/superseriousbusiness/gotosocial/internal/uris"
 )
 
 const (
-	confirmEmailPath = "/" + uris.ConfirmEmailPath
-	profilePath      = "/@:" + usernameKey
-	customCSSPath    = profilePath + "/custom.css"
-	rssFeedPath      = profilePath + "/feed.rss"
-	statusPath       = profilePath + "/statuses/:" + statusIDKey
-	assetsPathPrefix = "/assets"
-	distPathPrefix   = assetsPathPrefix + "/dist"
-	userPanelPath    = "/settings/user"
-	adminPanelPath   = "/settings/admin"
+	confirmEmailPath   = "/" + uris.ConfirmEmailPath
+	profilePath        = "/@:" + usernameKey
+	customCSSPath      = profilePath + "/custom.css"
+	rssFeedPath        = profilePath + "/feed.rss"
+	statusPath         = profilePath + "/statuses/:" + statusIDKey
+	assetsPathPrefix   = "/assets"
+	distPathPrefix     = assetsPathPrefix + "/dist"
+	settingsPathPrefix = "/settings"
+	settingsPanelGlob  = settingsPathPrefix + "/*panel"
+	userPanelPath      = settingsPathPrefix + "/user"
+	adminPanelPath     = settingsPathPrefix + "/admin"
 
 	tokenParam  = "token"
 	usernameKey = "username"
@@ -54,67 +56,54 @@ const (
 	lastModifiedHeader    = "Last-Modified"     // https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Last-Modified
 )
 
-// Module implements the api.ClientModule interface for web pages.
 type Module struct {
 	processor processing.Processor
 	eTagCache cache.Cache[string, eTagCacheEntry]
 }
 
-// New returns a new api.ClientModule for web pages.
-func New(processor processing.Processor) api.ClientModule {
+func New(processor processing.Processor) *Module {
 	return &Module{
 		processor: processor,
 		eTagCache: newETagCache(),
 	}
 }
 
-// Route satisfies the RESTAPIModule interface
-func (m *Module) Route(s router.Router) error {
+func (m *Module) Route(r router.Router) {
 	// serve static files from assets dir at /assets
-	assetsGroup := s.AttachGroup(assetsPathPrefix)
-	m.mountAssetsFilesystem(assetsGroup)
-
-	s.AttachHandler(http.MethodGet, "/settings", m.SettingsPanelHandler)
-	s.AttachHandler(http.MethodGet, "/settings/*panel", m.SettingsPanelHandler)
-
-	// User panel redirects
-	// used by clients
-	s.AttachHandler(http.MethodGet, "/auth/edit", func(c *gin.Context) {
-		c.Redirect(http.StatusMovedPermanently, userPanelPath)
-	})
-
-	// old version of settings panel
-	s.AttachHandler(http.MethodGet, "/user", func(c *gin.Context) {
-		c.Redirect(http.StatusMovedPermanently, userPanelPath)
-	})
-
-	// Admin panel redirects
-	// old version of settings panel
-	s.AttachHandler(http.MethodGet, "/admin", func(c *gin.Context) {
-		c.Redirect(http.StatusMovedPermanently, adminPanelPath)
-	})
-
-	// serve front-page
-	s.AttachHandler(http.MethodGet, "/", m.baseHandler)
+	assetsGroup := r.AttachGroup(assetsPathPrefix)
+	webAssetsAbsFilePath, err := filepath.Abs(config.GetWebAssetBaseDir())
+	if err != nil {
+		log.Panicf("error getting absolute path of assets dir: %s", err)
+	}
 
-	// serve profile pages at /@username
-	s.AttachHandler(http.MethodGet, profilePath, m.profileGETHandler)
+	fs := fileSystem{http.Dir(webAssetsAbsFilePath)}
 
-	// serve custom css at /@username/custom.css
-	s.AttachHandler(http.MethodGet, customCSSPath, m.customCSSGETHandler)
+	// use the cache middleware on all handlers in this group
+	assetsGroup.Use(m.assetsCacheControlMiddleware(fs))
 
-	s.AttachHandler(http.MethodGet, rssFeedPath, m.rssFeedGETHandler)
+	// serve static file system in the root of this group,
+	// will end up being something like "/assets/"
+	assetsGroup.StaticFS("/", fs)
 
-	// serve statuses
-	s.AttachHandler(http.MethodGet, statusPath, m.threadGETHandler)
+	/*
+		Attach individual web handlers which require no specific middlewares
+	*/
 
-	// serve email confirmation page at /confirm_email?token=whatever
-	s.AttachHandler(http.MethodGet, confirmEmailPath, m.confirmEmailGETHandler)
+	r.AttachHandler(http.MethodGet, "/", m.baseHandler) // front-page
+	r.AttachHandler(http.MethodGet, settingsPathPrefix, m.SettingsPanelHandler)
+	r.AttachHandler(http.MethodGet, settingsPanelGlob, m.SettingsPanelHandler)
+	r.AttachHandler(http.MethodGet, profilePath, m.profileGETHandler)
+	r.AttachHandler(http.MethodGet, customCSSPath, m.customCSSGETHandler)
+	r.AttachHandler(http.MethodGet, rssFeedPath, m.rssFeedGETHandler)
+	r.AttachHandler(http.MethodGet, statusPath, m.threadGETHandler)
+	r.AttachHandler(http.MethodGet, confirmEmailPath, m.confirmEmailGETHandler)
+	r.AttachHandler(http.MethodGet, robotsPath, m.robotsGETHandler)
 
-	// 404 handler
-	s.AttachNoRouteHandler(func(c *gin.Context) {
-		api.ErrorHandler(c, gtserror.NewErrorNotFound(errors.New(http.StatusText(http.StatusNotFound))), m.processor.InstanceGet)
-	})
+	/*
+		Attach redirects from old endpoints to current ones for backwards compatibility
+	*/
 
-	return nil
+	r.AttachHandler(http.MethodGet, "/auth/edit", func(c *gin.Context) { c.Redirect(http.StatusMovedPermanently, userPanelPath) })
+	r.AttachHandler(http.MethodGet, "/user", func(c *gin.Context) { c.Redirect(http.StatusMovedPermanently, userPanelPath) })
+	r.AttachHandler(http.MethodGet, "/admin", func(c *gin.Context) { c.Redirect(http.StatusMovedPermanently, adminPanelPath) })
 }