[performance] refactoring + add fave / follow / request / visibility caching (#1607)

* refactor visibility checking, add caching for visibility

* invalidate visibility cache items on account / status deletes

* fix requester ID passed to visibility cache nil ptr

* de-interface caches, fix home / public timeline caching + visibility

* finish adding code comments for visibility filter

* fix angry goconst linter warnings

* actually finish adding filter visibility code comments for timeline functions

* move home timeline status author check to after visibility

* remove now-unused code

* add more code comments

* add TODO code comment, update printed cache start names

* update printed cache names on stop

* start adding separate follow(request) delete db functions, add specific visibility cache tests

* add relationship type caching

* fix getting local account follows / followed-bys, other small codebase improvements

* simplify invalidation using cache hooks, add more GetAccountBy___() functions

* fix boosting to return 404 if not boostable but no error (to not leak status ID)

* remove dead code

* improved placement of cache invalidation

* update license headers

* add example follow, follow-request config entries

* add example visibility cache configuration to config file

* use specific PutFollowRequest() instead of just Put()

* add tests for all GetAccountBy()

* add GetBlockBy() tests

* update block to check primitive fields

* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests

* fix copy-pasted code

* update envparsing test

* whitespace

* fix bun struct tag

* add license header to gtscontext

* fix old license header

* improved error creation to not use fmt.Errorf() when not needed

* fix various rebase conflicts, fix account test

* remove commented-out code, fix-up mention caching

* fix mention select bun statement

* ensure mention target account populated, pass in context to customrenderer logging

* remove more uncommented code, fix typeutil test

* add statusfave database model caching

* add status fave cache configuration

* add status fave cache example config

* woops, catch missed error. nice catch linter!

* add back testrig panic on nil db

* update example configuration to match defaults, slight tweak to cache configuration defaults

* update envparsing test with new defaults

* fetch followingget to use the follow target account

* use accounnt.IsLocal() instead of empty domain check

* use constants for the cache visibility type check

* use bun.In() for notification type restriction in db query

* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())

* use bun query building for nested select statements to ensure working with postgres

* update public timeline future status checks to match visibility filter

* same as previous, for home timeline

* update public timeline tests to dynamically check for appropriate statuses

* migrate accounts to allow unique constraint on public_key

* provide minimal account with publicKey

---------

Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>

1 files changed, 0 insertions, 119 deletions

diff --git a/internal/visibility/statusvisible_test.go b/internal/visibility/statusvisible_test.go
deleted file mode 100644
index bd799d7ca..000000000
--- a/internal/visibility/statusvisible_test.go
+++ /dev/null
@@ -1,119 +0,0 @@
-// GoToSocial
-// Copyright (C) GoToSocial Authors admin@gotosocial.org
-// SPDX-License-Identifier: AGPL-3.0-or-later
-//
-// This program is free software: you can redistribute it and/or modify
-// it under the terms of the GNU Affero General Public License as published by
-// the Free Software Foundation, either version 3 of the License, or
-// (at your option) any later version.
-//
-// This program is distributed in the hope that it will be useful,
-// but WITHOUT ANY WARRANTY; without even the implied warranty of
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-// GNU Affero General Public License for more details.
-//
-// You should have received a copy of the GNU Affero General Public License
-// along with this program.  If not, see <http://www.gnu.org/licenses/>.
-
-package visibility_test
-
-import (
-	"context"
-	"testing"
-
-	"github.com/stretchr/testify/suite"
-	"github.com/superseriousbusiness/gotosocial/internal/gtsmodel"
-)
-
-type StatusVisibleTestSuite struct {
-	FilterStandardTestSuite
-}
-
-func (suite *StatusVisibleTestSuite) TestOwnStatusVisible() {
-	testStatus := suite.testStatuses["local_account_1_status_1"]
-	testAccount := suite.testAccounts["local_account_1"]
-	ctx := context.Background()
-
-	visible, err := suite.filter.StatusVisible(ctx, testStatus, testAccount)
-	suite.NoError(err)
-
-	suite.True(visible)
-}
-
-func (suite *StatusVisibleTestSuite) TestOwnDMVisible() {
-	ctx := context.Background()
-
-	testStatusID := suite.testStatuses["local_account_2_status_6"].ID
-	testStatus, err := suite.db.GetStatusByID(ctx, testStatusID)
-	suite.NoError(err)
-	testAccount := suite.testAccounts["local_account_2"]
-
-	visible, err := suite.filter.StatusVisible(ctx, testStatus, testAccount)
-	suite.NoError(err)
-
-	suite.True(visible)
-}
-
-func (suite *StatusVisibleTestSuite) TestDMVisibleToTarget() {
-	ctx := context.Background()
-
-	testStatusID := suite.testStatuses["local_account_2_status_6"].ID
-	testStatus, err := suite.db.GetStatusByID(ctx, testStatusID)
-	suite.NoError(err)
-	testAccount := suite.testAccounts["local_account_1"]
-
-	visible, err := suite.filter.StatusVisible(ctx, testStatus, testAccount)
-	suite.NoError(err)
-
-	suite.True(visible)
-}
-
-func (suite *StatusVisibleTestSuite) TestDMNotVisibleIfNotMentioned() {
-	ctx := context.Background()
-
-	testStatusID := suite.testStatuses["local_account_2_status_6"].ID
-	testStatus, err := suite.db.GetStatusByID(ctx, testStatusID)
-	suite.NoError(err)
-	testAccount := suite.testAccounts["admin_account"]
-
-	visible, err := suite.filter.StatusVisible(ctx, testStatus, testAccount)
-	suite.NoError(err)
-
-	suite.False(visible)
-}
-
-func (suite *StatusVisibleTestSuite) TestStatusNotVisibleIfNotMutuals() {
-	ctx := context.Background()
-
-	suite.db.DeleteByID(ctx, suite.testFollows["local_account_2_local_account_1"].ID, &gtsmodel.Follow{})
-
-	testStatusID := suite.testStatuses["local_account_1_status_4"].ID
-	testStatus, err := suite.db.GetStatusByID(ctx, testStatusID)
-	suite.NoError(err)
-	testAccount := suite.testAccounts["local_account_2"]
-
-	visible, err := suite.filter.StatusVisible(ctx, testStatus, testAccount)
-	suite.NoError(err)
-
-	suite.False(visible)
-}
-
-func (suite *StatusVisibleTestSuite) TestStatusNotVisibleIfNotFollowing() {
-	ctx := context.Background()
-
-	suite.db.DeleteByID(ctx, suite.testFollows["admin_account_local_account_1"].ID, &gtsmodel.Follow{})
-
-	testStatusID := suite.testStatuses["local_account_1_status_5"].ID
-	testStatus, err := suite.db.GetStatusByID(ctx, testStatusID)
-	suite.NoError(err)
-	testAccount := suite.testAccounts["admin_account"]
-
-	visible, err := suite.filter.StatusVisible(ctx, testStatus, testAccount)
-	suite.NoError(err)
-
-	suite.False(visible)
-}
-
-func TestStatusVisibleTestSuite(t *testing.T) {
-	suite.Run(t, new(StatusVisibleTestSuite))
-}