[performance] refactoring + add fave / follow / request / visibility caching (#1607)

* refactor visibility checking, add caching for visibility

* invalidate visibility cache items on account / status deletes

* fix requester ID passed to visibility cache nil ptr

* de-interface caches, fix home / public timeline caching + visibility

* finish adding code comments for visibility filter

* fix angry goconst linter warnings

* actually finish adding filter visibility code comments for timeline functions

* move home timeline status author check to after visibility

* remove now-unused code

* add more code comments

* add TODO code comment, update printed cache start names

* update printed cache names on stop

* start adding separate follow(request) delete db functions, add specific visibility cache tests

* add relationship type caching

* fix getting local account follows / followed-bys, other small codebase improvements

* simplify invalidation using cache hooks, add more GetAccountBy___() functions

* fix boosting to return 404 if not boostable but no error (to not leak status ID)

* remove dead code

* improved placement of cache invalidation

* update license headers

* add example follow, follow-request config entries

* add example visibility cache configuration to config file

* use specific PutFollowRequest() instead of just Put()

* add tests for all GetAccountBy()

* add GetBlockBy() tests

* update block to check primitive fields

* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests

* fix copy-pasted code

* update envparsing test

* whitespace

* fix bun struct tag

* add license header to gtscontext

* fix old license header

* improved error creation to not use fmt.Errorf() when not needed

* fix various rebase conflicts, fix account test

* remove commented-out code, fix-up mention caching

* fix mention select bun statement

* ensure mention target account populated, pass in context to customrenderer logging

* remove more uncommented code, fix typeutil test

* add statusfave database model caching

* add status fave cache configuration

* add status fave cache example config

* woops, catch missed error. nice catch linter!

* add back testrig panic on nil db

* update example configuration to match defaults, slight tweak to cache configuration defaults

* update envparsing test with new defaults

* fetch followingget to use the follow target account

* use accounnt.IsLocal() instead of empty domain check

* use constants for the cache visibility type check

* use bun.In() for notification type restriction in db query

* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())

* use bun query building for nested select statements to ensure working with postgres

* update public timeline future status checks to match visibility filter

* same as previous, for home timeline

* update public timeline tests to dynamically check for appropriate statuses

* migrate accounts to allow unique constraint on public_key

* provide minimal account with publicKey

---------

Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>

1 files changed, 0 insertions, 126 deletions

diff --git a/internal/visibility/statushometimelineable.go b/internal/visibility/statushometimelineable.go
deleted file mode 100644
index b5d5b836e..000000000
--- a/internal/visibility/statushometimelineable.go
+++ /dev/null
@@ -1,126 +0,0 @@
-// GoToSocial
-// Copyright (C) GoToSocial Authors admin@gotosocial.org
-// SPDX-License-Identifier: AGPL-3.0-or-later
-//
-// This program is free software: you can redistribute it and/or modify
-// it under the terms of the GNU Affero General Public License as published by
-// the Free Software Foundation, either version 3 of the License, or
-// (at your option) any later version.
-//
-// This program is distributed in the hope that it will be useful,
-// but WITHOUT ANY WARRANTY; without even the implied warranty of
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-// GNU Affero General Public License for more details.
-//
-// You should have received a copy of the GNU Affero General Public License
-// along with this program.  If not, see <http://www.gnu.org/licenses/>.
-
-package visibility
-
-import (
-	"context"
-	"fmt"
-	"time"
-
-	"codeberg.org/gruf/go-kv"
-	"github.com/superseriousbusiness/gotosocial/internal/gtsmodel"
-	"github.com/superseriousbusiness/gotosocial/internal/id"
-	"github.com/superseriousbusiness/gotosocial/internal/log"
-)
-
-func (f *filter) StatusHometimelineable(ctx context.Context, targetStatus *gtsmodel.Status, timelineOwnerAccount *gtsmodel.Account) (bool, error) {
-	l := log.WithContext(ctx).
-		WithFields(kv.Fields{{"statusID", targetStatus.ID}}...)
-
-	// don't timeline statuses more than 5 min in the future
-	maxID, err := id.NewULIDFromTime(time.Now().Add(5 * time.Minute))
-	if err != nil {
-		return false, err
-	}
-
-	if targetStatus.ID > maxID {
-		l.Debug("status not hometimelineable because it's from more than 5 minutes in the future")
-		return false, nil
-	}
-
-	// status owner should always be able to see their own status in their timeline so we can return early if this is the case
-	if targetStatus.AccountID == timelineOwnerAccount.ID {
-		return true, nil
-	}
-
-	v, err := f.StatusVisible(ctx, targetStatus, timelineOwnerAccount)
-	if err != nil {
-		return false, fmt.Errorf("StatusHometimelineable: error checking visibility of status with id %s: %s", targetStatus.ID, err)
-	}
-
-	if !v {
-		l.Debug("status is not hometimelineable because it's not visible to the requester")
-		return false, nil
-	}
-
-	for _, m := range targetStatus.Mentions {
-		if m.TargetAccountID == timelineOwnerAccount.ID {
-			// if we're mentioned we should be able to see the post
-			return true, nil
-		}
-	}
-
-	// check we follow the originator of the status
-	if targetStatus.Account == nil {
-		tsa, err := f.db.GetAccountByID(ctx, targetStatus.AccountID)
-		if err != nil {
-			return false, fmt.Errorf("StatusHometimelineable: error getting status author account with id %s: %s", targetStatus.AccountID, err)
-		}
-		targetStatus.Account = tsa
-	}
-	following, err := f.db.IsFollowing(ctx, timelineOwnerAccount, targetStatus.Account)
-	if err != nil {
-		return false, fmt.Errorf("StatusHometimelineable: error checking if %s follows %s: %s", timelineOwnerAccount.ID, targetStatus.AccountID, err)
-	}
-	if !following {
-		return false, nil
-	}
-
-	// Don't timeline a status whose parent hasn't been dereferenced yet or can't be dereferenced.
-	// If we have the reply to URI but don't have an ID for the replied-to account or the replied-to status in our database, we haven't dereferenced it yet.
-	if targetStatus.InReplyToURI != "" && (targetStatus.InReplyToID == "" || targetStatus.InReplyToAccountID == "") {
-		return false, nil
-	}
-
-	// if a status replies to an ID we know in the database, we need to check that parent status too
-	if targetStatus.InReplyToID != "" {
-		// pin the reply to status on to this status if it hasn't been done already
-		if targetStatus.InReplyTo == nil {
-			rs, err := f.db.GetStatusByID(ctx, targetStatus.InReplyToID)
-			if err != nil {
-				return false, fmt.Errorf("StatusHometimelineable: error getting replied to status with id %s: %s", targetStatus.InReplyToID, err)
-			}
-			targetStatus.InReplyTo = rs
-		}
-
-		// pin the reply to account on to this status if it hasn't been done already
-		if targetStatus.InReplyToAccount == nil {
-			ra, err := f.db.GetAccountByID(ctx, targetStatus.InReplyToAccountID)
-			if err != nil {
-				return false, fmt.Errorf("StatusHometimelineable: error getting replied to account with id %s: %s", targetStatus.InReplyToAccountID, err)
-			}
-			targetStatus.InReplyToAccount = ra
-		}
-
-		// if it's a reply to the timelineOwnerAccount, we don't need to check if the timelineOwnerAccount follows itself, just return true, they can see it
-		if targetStatus.InReplyToAccountID == timelineOwnerAccount.ID {
-			return true, nil
-		}
-
-		// make sure the parent status is also home timelineable, otherwise we shouldn't timeline this one either
-		parentStatusTimelineable, err := f.StatusHometimelineable(ctx, targetStatus.InReplyTo, timelineOwnerAccount)
-		if err != nil {
-			return false, fmt.Errorf("StatusHometimelineable: error checking timelineability of parent status %s of status %s: %s", targetStatus.InReplyToID, targetStatus.ID, err)
-		}
-		if !parentStatusTimelineable {
-			return false, nil
-		}
-	}
-
-	return true, nil
-}