[chore] Admin CLI + new account creation refactoring (#2008)

* set maxPasswordLength to 72 bytes, rename validate function

* refactor NewSignup

* refactor admin account CLI commands

* refactor oidc create user

* refactor processor create

* tweak password change, check old != new password

1 files changed, 8 insertions, 8 deletions

diff --git a/internal/validate/formvalidation_test.go b/internal/validate/formvalidation_test.go
index accd48ab6..534e5b849 100644
--- a/internal/validate/formvalidation_test.go
+++ b/internal/validate/formvalidation_test.go
@@ -43,42 +43,42 @@ func (suite *ValidationTestSuite) TestCheckPasswordStrength() {
 	strongPassword := "3dX5@Zc%mV*W2MBNEy$@"
 	var err error
 
-	err = validate.NewPassword(empty)
+	err = validate.Password(empty)
 	if suite.Error(err) {
 		suite.Equal(errors.New("no password provided / provided password was 0 bytes"), err)
 	}
 
-	err = validate.NewPassword(terriblePassword)
+	err = validate.Password(terriblePassword)
 	if suite.Error(err) {
 		suite.Equal(errors.New("password is only 62% strength, try including more special characters, using uppercase letters, using numbers or using a longer password"), err)
 	}
 
-	err = validate.NewPassword(weakPassword)
+	err = validate.Password(weakPassword)
 	if suite.Error(err) {
 		suite.Equal(errors.New("password is only 95% strength, try including more special characters, using numbers or using a longer password"), err)
 	}
 
-	err = validate.NewPassword(shortPassword)
+	err = validate.Password(shortPassword)
 	if suite.Error(err) {
 		suite.Equal(errors.New("password is only 39% strength, try including more special characters or using a longer password"), err)
 	}
 
-	err = validate.NewPassword(specialPassword)
+	err = validate.Password(specialPassword)
 	if suite.Error(err) {
 		suite.Equal(errors.New("password is only 53% strength, try including more special characters or using a longer password"), err)
 	}
 
-	err = validate.NewPassword(longPassword)
+	err = validate.Password(longPassword)
 	if suite.NoError(err) {
 		suite.Equal(nil, err)
 	}
 
-	err = validate.NewPassword(tooLong)
+	err = validate.Password(tooLong)
 	if suite.Error(err) {
 		suite.Equal(errors.New("password should be no more than 72 bytes, provided password was 571 bytes"), err)
 	}
 
-	err = validate.NewPassword(strongPassword)
+	err = validate.Password(strongPassword)
 	if suite.NoError(err) {
 		suite.Equal(nil, err)
 	}