[chore] use our own logging implementation (#716)

* first commit

Signed-off-by: kim <grufwub@gmail.com>

* replace logging with our own log library

Signed-off-by: kim <grufwub@gmail.com>

* fix imports

Signed-off-by: kim <grufwub@gmail.com>

* fix log imports

Signed-off-by: kim <grufwub@gmail.com>

* add license text

Signed-off-by: kim <grufwub@gmail.com>

* fix package import cycle between config and log package

Signed-off-by: kim <grufwub@gmail.com>

* fix empty kv.Fields{} being passed to WithFields()

Signed-off-by: kim <grufwub@gmail.com>

* fix uses of log.WithFields() with whitespace issues and empty slices

Signed-off-by: kim <grufwub@gmail.com>

* *linter related grumbling*

Signed-off-by: kim <grufwub@gmail.com>

* gofmt the codebase! also fix more log.WithFields() formatting issues

Signed-off-by: kim <grufwub@gmail.com>

* update testrig code to match new changes

Signed-off-by: kim <grufwub@gmail.com>

* fix error wrapping in non fmt.Errorf function

Signed-off-by: kim <grufwub@gmail.com>

* add benchmarking of log.Caller() vs non-cached

Signed-off-by: kim <grufwub@gmail.com>

* fix syslog tests, add standard build tags to test runner to ensure consistency

Signed-off-by: kim <grufwub@gmail.com>

* make syslog tests more robust

Signed-off-by: kim <grufwub@gmail.com>

* fix caller depth arithmatic (is that how you spell it?)

Signed-off-by: kim <grufwub@gmail.com>

* update to use unkeyed fields in kv.Field{} instances

Signed-off-by: kim <grufwub@gmail.com>

* update go-kv library

Signed-off-by: kim <grufwub@gmail.com>

* update libraries list

Signed-off-by: kim <grufwub@gmail.com>

* fuck you linter get nerfed

Signed-off-by: kim <grufwub@gmail.com>

Co-authored-by: tobi <31960611+tsmethurst@users.noreply.github.com>

3 files changed, 11 insertions, 3 deletions

diff --git a/internal/storage/local.go b/internal/storage/local.go
index da57631f9..8ed3ca8d8 100644
--- a/internal/storage/local.go
+++ b/internal/storage/local.go
@@ -33,18 +33,23 @@ type Local struct {
 func (l *Local) Get(ctx context.Context, key string) ([]byte, error) {
 	return l.KVStore.Get(key)
 }
+
 func (l *Local) GetStream(ctx context.Context, key string) (io.ReadCloser, error) {
 	return l.KVStore.GetStream(key)
 }
+
 func (l *Local) PutStream(ctx context.Context, key string, r io.Reader) error {
 	return l.KVStore.PutStream(key, r)
 }
+
 func (l *Local) Put(ctx context.Context, key string, value []byte) error {
 	return l.KVStore.Put(key, value)
 }
+
 func (l *Local) Delete(ctx context.Context, key string) error {
 	return l.KVStore.Delete(key)
 }
+
 func (l *Local) URL(ctx context.Context, key string) *url.URL {
 	return nil
 }
diff --git a/internal/storage/s3.go b/internal/storage/s3.go
index a15114488..ee51bea89 100644
--- a/internal/storage/s3.go
+++ b/internal/storage/s3.go
@@ -55,6 +55,7 @@ func (s *S3) Get(ctx context.Context, key string) ([]byte, error) {
 	}
 	return b, nil
 }
+
 func (s *S3) GetStream(ctx context.Context, key string) (io.ReadCloser, error) {
 	o, err := s.mc.GetObject(ctx, s.bucket, key, minio.GetObjectOptions{})
 	if err != nil {
@@ -62,21 +63,25 @@ func (s *S3) GetStream(ctx context.Context, key string) (io.ReadCloser, error) {
 	}
 	return o, err
 }
+
 func (s *S3) PutStream(ctx context.Context, key string, r io.Reader) error {
 	if _, err := s.mc.PutObject(ctx, s.bucket, key, r, -1, minio.PutObjectOptions{}); err != nil {
 		return fmt.Errorf("uploading data stream: %w", err)
 	}
 	return nil
 }
+
 func (s *S3) Put(ctx context.Context, key string, value []byte) error {
 	if _, err := s.mc.PutObject(ctx, s.bucket, key, bytes.NewBuffer(value), -1, minio.PutObjectOptions{}); err != nil {
 		return fmt.Errorf("uploading data slice: %w", err)
 	}
 	return nil
 }
+
 func (s *S3) Delete(ctx context.Context, key string) error {
 	return s.mc.RemoveObject(ctx, s.bucket, key, minio.RemoveObjectOptions{})
 }
+
 func (s *S3) URL(ctx context.Context, key string) *url.URL {
 	// it's safe to ignore the error here, as we just fall back to fetching the
 	// file if the url request fails
diff --git a/internal/storage/storage.go b/internal/storage/storage.go
index 88577442f..7a4ebc6c3 100644
--- a/internal/storage/storage.go
+++ b/internal/storage/storage.go
@@ -33,9 +33,7 @@ import (
 	"github.com/superseriousbusiness/gotosocial/internal/config"
 )
 
-var (
-	ErrNotSupported = errors.New("driver does not suppport functionality")
-)
+var ErrNotSupported = errors.New("driver does not suppport functionality")
 
 // Driver implements the functionality to store and retrieve blobs
 // (images,video,audio)