summaryrefslogtreecommitdiff
path: root/internal/processing
diff options
context:
space:
mode:
authorLibravatar kim <89579420+NyaaaWhatsUpDoc@users.noreply.github.com>2023-11-30 16:22:34 +0000
committerLibravatar GitHub <noreply@github.com>2023-11-30 16:22:34 +0000
commiteb170003b81504ba6eb85f950c223dc9eaf1cfca (patch)
treef1f9779e14875faa70f4db85a8cf19100633884d /internal/processing
parent[bugfix] always go through status parent dereferencing on isNew, even on data... (diff)
downloadgotosocial-eb170003b81504ba6eb85f950c223dc9eaf1cfca.tar.xz
[bugfix] return 400 Bad Request on more cases of malformed AS data (#2399)
Diffstat (limited to 'internal/processing')
-rw-r--r--internal/processing/admin/email.go2
-rw-r--r--internal/processing/search/get.go6
-rw-r--r--internal/processing/search/lookup.go2
3 files changed, 5 insertions, 5 deletions
diff --git a/internal/processing/admin/email.go b/internal/processing/admin/email.go
index 88396db76..fb78f1fcc 100644
--- a/internal/processing/admin/email.go
+++ b/internal/processing/admin/email.go
@@ -47,7 +47,7 @@ func (p *Processor) EmailTest(ctx context.Context, account *gtsmodel.Account, to
}
if err := p.emailSender.SendTestEmail(toAddress, testData); err != nil {
- if errorType := gtserror.Type(err); errorType == gtserror.TypeSMTP {
+ if gtserror.IsSMTP(err) {
// An error occurred during the SMTP part.
// We should indicate this to the caller, as
// it will likely help them debug the issue.
diff --git a/internal/processing/search/get.go b/internal/processing/search/get.go
index 4c09f05bb..6b2125d81 100644
--- a/internal/processing/search/get.go
+++ b/internal/processing/search/get.go
@@ -382,7 +382,7 @@ func (p *Processor) accountsByNamestring(
if err != nil {
// Check for semi-expected error types.
// On one of these, we can continue.
- if !gtserror.Unretrievable(err) && !gtserror.WrongType(err) {
+ if !gtserror.IsUnretrievable(err) && !gtserror.IsWrongType(err) {
err = gtserror.Newf("error looking up @%s@%s as account: %w", username, domain, err)
return gtserror.NewErrorInternalError(err)
}
@@ -491,7 +491,7 @@ func (p *Processor) byURI(
if err != nil {
// Check for semi-expected error types.
// On one of these, we can continue.
- if !gtserror.Unretrievable(err) && !gtserror.WrongType(err) {
+ if !gtserror.IsUnretrievable(err) && !gtserror.IsWrongType(err) {
err = gtserror.Newf("error looking up %s as account: %w", uri, err)
return gtserror.NewErrorInternalError(err)
}
@@ -509,7 +509,7 @@ func (p *Processor) byURI(
if err != nil {
// Check for semi-expected error types.
// On one of these, we can continue.
- if !gtserror.Unretrievable(err) && !gtserror.WrongType(err) {
+ if !gtserror.IsUnretrievable(err) && !gtserror.IsWrongType(err) {
err = gtserror.Newf("error looking up %s as status: %w", uri, err)
return gtserror.NewErrorInternalError(err)
}
diff --git a/internal/processing/search/lookup.go b/internal/processing/search/lookup.go
index b6f1eef52..f5c131841 100644
--- a/internal/processing/search/lookup.go
+++ b/internal/processing/search/lookup.go
@@ -92,7 +92,7 @@ func (p *Processor) Lookup(
false, // never resolve!
)
if err != nil {
- if gtserror.Unretrievable(err) {
+ if gtserror.IsUnretrievable(err) {
// ErrNotRetrievable is fine, just wrap it in
// a 404 to indicate we couldn't find anything.
err := fmt.Errorf("%s not found", query)