diff options
| author |  kim <89579420+NyaaaWhatsUpDoc@users.noreply.github.com> | 2023-02-03 20:03:05 +0000 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2023-02-03 20:03:05 +0000 |
| commit | 33aee1b1e974e99182a95ce1a05e2be924d19bb2 (patch) | |
| tree | 1471623039f70325a0b7a1c25dd4fe3afc883970 /internal/processing/status | |
| parent | [feature/frogend] (Mastodon) domain block CSV import (#1390) (diff) | |
| download | gotosocial-33aee1b1e974e99182a95ce1a05e2be924d19bb2.tar.xz | |
[chore] reformat GetAccount() functionality, support updating accounts based on last_fetch (#1411)
* reformat GetAccount() functionality, and add UpdateAccount() function.
* use fetched_at instead of last_webfingered_at
* catch local "not found" errors. small formatting / error string changes
* remove now unused error type
* return nil when wrapping nil error
* update expected error messages
* return correct url for foss satan webfinger
* add AP model for Some_User
* normalize local domain
* return notretrievable where appropriate
* expose NewErrNotRetrievable
* ensure webfinger for new accounts searched by uri
* update local account short circuit
* allow enrich to fail for already-known accounts
* remove unused LastWebfingeredAt
* expose test maps on mock http client
* update Update test
* reformat GetAccount() functionality, and add UpdateAccount() function.
* use fetched_at instead of last_webfingered_at
* catch local "not found" errors. small formatting / error string changes
* remove nil error checks (we shouldn't be passing nil errors to newError() initializers)
* remove mutex unlock on transport init fail (it hasn't yet been locked!)
* woops add back the error wrapping to use ErrNotRetrievable
* caches were never being started... :see_no_evil:
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
Diffstat (limited to 'internal/processing/status')
| -rw-r--r-- | internal/processing/status/bookmark.go | 7 | ||||
| -rw-r--r-- | internal/processing/status/create.go | 6 | ||||
| -rw-r--r-- | internal/processing/status/fave.go | 5 |
3 files changed, 3 insertions, 15 deletions
diff --git a/internal/processing/status/bookmark.go b/internal/processing/status/bookmark.go index 6f5c7f633..3cf64490a 100644 --- a/internal/processing/status/bookmark.go +++ b/internal/processing/status/bookmark.go @@ -55,14 +55,9 @@ func (p *processor) Bookmark(ctx context.Context, requestingAccount *gtsmodel.Ac } if newBookmark { - thisBookmarkID, err := id.NewULID() - if err != nil { - return nil, gtserror.NewErrorInternalError(err) - } - // we need to create a new bookmark in the database gtsBookmark := >smodel.StatusBookmark{ - ID: thisBookmarkID, + ID: id.NewULID(), AccountID: requestingAccount.ID, Account: requestingAccount, TargetAccountID: targetStatus.AccountID, diff --git a/internal/processing/status/create.go b/internal/processing/status/create.go index 9e9d24c84..5bc1629c4 100644 --- a/internal/processing/status/create.go +++ b/internal/processing/status/create.go @@ -35,11 +35,7 @@ import ( func (p *processor) Create(ctx context.Context, account *gtsmodel.Account, application *gtsmodel.Application, form *apimodel.AdvancedStatusCreateForm) (*apimodel.Status, gtserror.WithCode) { accountURIs := uris.GenerateURIsForAccount(account.Username) - thisStatusID, err := id.NewULID() - if err != nil { - return nil, gtserror.NewErrorInternalError(err) - } - + thisStatusID := id.NewULID() local := true sensitive := form.Sensitive diff --git a/internal/processing/status/fave.go b/internal/processing/status/fave.go index 3686eb96f..dd5d338b3 100644 --- a/internal/processing/status/fave.go +++ b/internal/processing/status/fave.go @@ -62,10 +62,7 @@ func (p *processor) Fave(ctx context.Context, requestingAccount *gtsmodel.Accoun } if newFave { - thisFaveID, err := id.NewULID() - if err != nil { - return nil, gtserror.NewErrorInternalError(err) - } + thisFaveID := id.NewULID() // we need to create a new fave in the database gtsFave := >smodel.StatusFave{ |