[feature] Use `hidesToPublicFromUnauthedWeb` and `hidesCcPublicFromUnauthedWeb` properties for web visibility of statuses (#4315)

This pull request implements two new properties on ActivityPub actors: `hidesToPublicFromUnauthedWeb` and `hidesCcPublicFromUnauthedWeb`.

As documented, these properties allow actors to signal their preference for whether or not their posts should be hidden from unauthenticated web views (ie., web pages like the GtS frontend, web apps like the Mastodon frontend, web APIs like the Mastodon public timeline API, etc). This allows remote accounts to *opt in* to having their unlisted visibility posts shown in (for example) the replies section of the web view of a GtS thread. In future, we can also use these properties to determine whether we should show boosts of a remote actor's post on a GtS profile, and that sort of thing.

In keeping with our stance around privacy by default, GtS assumes `true` for `hidesCcPublicFromUnauthedWeb` if the property is not set on a remote actor, ie., hide unlisted/unlocked posts by default. `hidesToPublicFromUnauthedWeb` is assumed to be `false` if the property is not set on a remote actor, ie., show public posts by default.

~~WIP as I still want to work on the documentation for this a bit.~~

New props are already in the namespace document: https://gotosocial.org/ns

Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4315
Reviewed-by: kim <gruf@noreply.codeberg.org>
Co-authored-by: tobi <tobi.smethurst@protonmail.com>
Co-committed-by: tobi <tobi.smethurst@protonmail.com>

1 files changed, 31 insertions, 15 deletions

diff --git a/internal/processing/account/update.go b/internal/processing/account/update.go
index f0e3b790b..99dd074a5 100644
--- a/internal/processing/account/update.go
+++ b/internal/processing/account/update.go
@@ -212,6 +212,37 @@ func (p *Processor) Update(ctx context.Context, account *gtsmodel.Account, form
 		}
 	}
 
+	if form.WebVisibility != nil {
+		switch apimodel.Visibility(*form.WebVisibility) {
+
+		// Show none.
+		case apimodel.VisibilityNone:
+			account.HidesToPublicFromUnauthedWeb = util.Ptr(true)
+			account.HidesCcPublicFromUnauthedWeb = util.Ptr(true)
+
+		// Show public only (GtS default).
+		case apimodel.VisibilityPublic:
+			account.HidesToPublicFromUnauthedWeb = util.Ptr(false)
+			account.HidesCcPublicFromUnauthedWeb = util.Ptr(true)
+
+		// Show public and unlisted (Masto default).
+		case apimodel.VisibilityUnlisted:
+			account.HidesToPublicFromUnauthedWeb = util.Ptr(false)
+			account.HidesCcPublicFromUnauthedWeb = util.Ptr(false)
+
+		default:
+			const text = "web_visibility must be one of public, unlisted, or none"
+			err := errors.New(text)
+			return nil, gtserror.NewErrorBadRequest(err, text)
+		}
+
+		acctColumns = append(
+			acctColumns,
+			"hides_to_public_from_unauthed_web",
+			"hides_cc_public_from_unauthed_web",
+		)
+	}
+
 	// Account settings flags.
 
 	if form.Source != nil {
@@ -287,21 +318,6 @@ func (p *Processor) Update(ctx context.Context, account *gtsmodel.Account, form
 		settingsColumns = append(settingsColumns, "hide_collections")
 	}
 
-	if form.WebVisibility != nil {
-		apiVis := apimodel.Visibility(*form.WebVisibility)
-		webVisibility := typeutils.APIVisToVis(apiVis)
-		if webVisibility != gtsmodel.VisibilityPublic &&
-			webVisibility != gtsmodel.VisibilityUnlocked &&
-			webVisibility != gtsmodel.VisibilityNone {
-			const text = "web_visibility must be one of public, unlocked, or none"
-			err := errors.New(text)
-			return nil, gtserror.NewErrorBadRequest(err, text)
-		}
-
-		account.Settings.WebVisibility = webVisibility
-		settingsColumns = append(settingsColumns, "web_visibility")
-	}
-
 	if form.WebLayout != nil {
 		webLayout := gtsmodel.ParseWebLayout(*form.WebLayout)
 		if webLayout == gtsmodel.WebLayoutUnknown {