reference global logrus (#274)

* reference logrus' global logger instead of passing and storing a logger reference everywhere

* always directly use global logrus logger instead of referencing an instance

* test suites should also directly use the global logrus logger

* rename gin logging function to clarify that it's middleware

* correct comments which erroneously referenced removed logger parameter

* setting log level for tests now uses logrus' exported type instead of the string value, to guarantee error isn't possible

1 files changed, 3 insertions, 5 deletions

diff --git a/internal/media/handler.go b/internal/media/handler.go
index 429dee88a..fb4ed307e 100644
--- a/internal/media/handler.go
+++ b/internal/media/handler.go
@@ -87,16 +87,14 @@ type mediaHandler struct {
 	config  *config.Config
 	db      db.DB
 	storage *kv.KVStore
-	log     *logrus.Logger
 }
 
-// New returns a new handler with the given config, db, storage, and logger
-func New(config *config.Config, database db.DB, storage *kv.KVStore, log *logrus.Logger) Handler {
+// New returns a new handler with the given config, db, and storage
+func New(config *config.Config, database db.DB, storage *kv.KVStore) Handler {
 	return &mediaHandler{
 		config:  config,
 		db:      database,
 		storage: storage,
-		log:     log,
 	}
 }
 
@@ -108,7 +106,7 @@ func New(config *config.Config, database db.DB, storage *kv.KVStore, log *logrus
 // puts it in whatever storage backend we're using, sets the relevant fields in the database for the new image,
 // and then returns information to the caller about the new header.
 func (mh *mediaHandler) ProcessHeaderOrAvatar(ctx context.Context, attachment []byte, accountID string, mediaType Type, remoteURL string) (*gtsmodel.MediaAttachment, error) {
-	l := mh.log.WithField("func", "SetHeaderForAccountID")
+	l := logrus.WithField("func", "SetHeaderForAccountID")
 
 	if mediaType != Header && mediaType != Avatar {
 		return nil, errors.New("header or avatar not selected")