[chore] reformat GetAccount() functionality, support updating accounts based on last_fetch (#1411)

* reformat GetAccount() functionality, and add UpdateAccount() function.

* use fetched_at instead of last_webfingered_at

* catch local "not found" errors. small formatting / error string changes

* remove now unused error type

* return nil when wrapping nil error

* update expected error messages

* return correct url for foss satan webfinger

* add AP model for Some_User

* normalize local domain

* return notretrievable where appropriate

* expose NewErrNotRetrievable

* ensure webfinger for new accounts searched by uri

* update local account short circuit

* allow enrich to fail for already-known accounts

* remove unused LastWebfingeredAt

* expose test maps on mock http client

* update Update test

* reformat GetAccount() functionality, and add UpdateAccount() function.

* use fetched_at instead of last_webfingered_at

* catch local "not found" errors. small formatting / error string changes

* remove nil error checks (we shouldn't be passing nil errors to newError() initializers)

* remove mutex unlock on transport init fail (it hasn't yet been locked!)

* woops add back the error wrapping to use ErrNotRetrievable

* caches were never being started... :see_no_evil:

---------

Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>

1 files changed, 7 insertions, 5 deletions

diff --git a/internal/id/ulid.go b/internal/id/ulid.go
index bed7cf046..e02870b48 100644
--- a/internal/id/ulid.go
+++ b/internal/id/ulid.go
@@ -35,13 +35,15 @@ const (
 // ULID represents a Universally Unique Lexicographically Sortable Identifier of 26 characters. See https://github.com/oklog/ulid
 type ULID string
 
-// NewULID returns a new ULID string using the current time, or an error if something goes wrong.
-func NewULID() (string, error) {
-	newUlid, err := ulid.New(ulid.Timestamp(time.Now()), rand.Reader)
+// NewULID returns a new ULID string using the current time.
+func NewULID() string {
+	ulid, err := ulid.New(
+		ulid.Timestamp(time.Now()), rand.Reader,
+	)
 	if err != nil {
-		return "", err
+		panic(err)
 	}
-	return newUlid.String(), nil
+	return ulid.String()
 }
 
 // NewULIDFromTime returns a new ULID string using the given time, or an error if something goes wrong.