diff options
| author |  tobi <31960611+tsmethurst@users.noreply.github.com> | 2023-06-14 15:08:31 +0200 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2023-06-14 15:08:31 +0200 |
| commit | 827cc4df56de0c4c201246c5c427ecda1bc73448 (patch) | |
| tree | 8de9c9a6af44ebfddf3a8d1f52d0f24a777f53d7 /internal/federation/federatingactor.go | |
| parent | [chore] Refactor AP authentication, other small bits of tidying up (#1874) (diff) | |
| download | gotosocial-827cc4df56de0c4c201246c5c427ecda1bc73448.tar.xz | |
[chore/bugfix] Demote failed inbox forwarding to warn log rather than error return (#1892)
Diffstat (limited to 'internal/federation/federatingactor.go')
| -rw-r--r-- | internal/federation/federatingactor.go | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/internal/federation/federatingactor.go b/internal/federation/federatingactor.go index 708114484..72647040a 100644 --- a/internal/federation/federatingactor.go +++ b/internal/federation/federatingactor.go @@ -231,8 +231,9 @@ func (f *federatingActor) PostInboxScheme(ctx context.Context, w http.ResponseWr // is updated, and/or federating callbacks are handled // properly. if !errors.Is(err, db.ErrAlreadyExists) { - err = fmt.Errorf("PostInboxScheme: error calling sideEffectActor.InboxForwarding: %w", err) - return false, gtserror.NewErrorInternalError(err) + // Failed inbox forwarding is not a show-stopper, + // and doesn't even necessarily denote a real error. + l.Warnf("error calling sideEffectActor.InboxForwarding: %q", err) } } |