summaryrefslogtreecommitdiff
path: root/internal/db
diff options
context:
space:
mode:
authorLibravatar Terin Stock <terinjokes@gmail.com>2022-04-28 00:43:41 -0700
committerLibravatar GitHub <noreply@github.com>2022-04-28 08:43:41 +0100
commit8e80f983b354f90a4a8b701383ce682c9163b59b (patch)
treed0b083ebc0ad34c5363efa9c33a3da3e7f8f409d /internal/db
parent[chore] Return more useful errors from auth failure (#494) (diff)
downloadgotosocial-8e80f983b354f90a4a8b701383ce682c9163b59b.tar.xz
[bugfix] use Exec to rename media_attachments (#498)
The `database/sql` package in the Go stdlib has two methods that can run queries against the database driver: `Query` and `Exec`. When the query returns rows, such as "SELECT", the package expects the use of `Query`, and returns `*sql.Rows`. When the query does not return rows, the package expects the use of `Exec`, which returns `sql.Result`. This changeset corrects the "media_attachments" migration to using `ExecContext`, as "ALTER TABLE" does not return rows. Signed-off-by: Terin Stock <terinjokes@gmail.com>
Diffstat (limited to 'internal/db')
-rw-r--r--internal/db/bundb/migrations/20220214175650_media_cleanup.go2
1 files changed, 1 insertions, 1 deletions
diff --git a/internal/db/bundb/migrations/20220214175650_media_cleanup.go b/internal/db/bundb/migrations/20220214175650_media_cleanup.go
index 427f3bb9e..c7734e6e7 100644
--- a/internal/db/bundb/migrations/20220214175650_media_cleanup.go
+++ b/internal/db/bundb/migrations/20220214175650_media_cleanup.go
@@ -142,7 +142,7 @@ func init() {
}
// rename the new table to the same name as the old table was
- if _, err := tx.QueryContext(ctx, "ALTER TABLE new_media_attachments RENAME TO media_attachments;"); err != nil {
+ if _, err := tx.ExecContext(ctx, "ALTER TABLE new_media_attachments RENAME TO media_attachments;"); err != nil {
return err
}