diff options
author | 2023-07-25 09:34:05 +0100 | |
---|---|---|
committer | 2023-07-25 10:34:05 +0200 | |
commit | 5f3e0957179eddd088e82b8f8f493164cbc9ce37 (patch) | |
tree | b169630ef1ac269dc96d74b533f6663dc0f1e6fc /internal/db/statusfave.go | |
parent | [feature/performance] support uncaching remote emoji + scheduled cleanup func... (diff) | |
download | gotosocial-5f3e0957179eddd088e82b8f8f493164cbc9ce37.tar.xz |
[performance] retry db queries on busy errors (#2025)
* catch SQLITE_BUSY errors, wrap bun.DB to use our own busy retrier, remove unnecessary db.Error type
Signed-off-by: kim <grufwub@gmail.com>
* remove dead code
Signed-off-by: kim <grufwub@gmail.com>
* remove more dead code, add missing error arguments
Signed-off-by: kim <grufwub@gmail.com>
* update sqlite to use maxOpenConns()
Signed-off-by: kim <grufwub@gmail.com>
* add uncommitted changes
Signed-off-by: kim <grufwub@gmail.com>
* use direct calls-through for the ConnIface to make sure we don't double query hook
Signed-off-by: kim <grufwub@gmail.com>
* expose underlying bun.DB better
Signed-off-by: kim <grufwub@gmail.com>
* retry on the correct busy error
Signed-off-by: kim <grufwub@gmail.com>
* use longer possible maxRetries for db retry-backoff
Signed-off-by: kim <grufwub@gmail.com>
* remove the note regarding max-open-conns only applying to postgres
Signed-off-by: kim <grufwub@gmail.com>
* improved code commenting
Signed-off-by: kim <grufwub@gmail.com>
* remove unnecessary infof call (just use info)
Signed-off-by: kim <grufwub@gmail.com>
* rename DBConn to WrappedDB to better follow sql package name conventions
Signed-off-by: kim <grufwub@gmail.com>
* update test error string checks
Signed-off-by: kim <grufwub@gmail.com>
* shush linter
Signed-off-by: kim <grufwub@gmail.com>
* update backoff logic to be more transparent
Signed-off-by: kim <grufwub@gmail.com>
---------
Signed-off-by: kim <grufwub@gmail.com>
Diffstat (limited to 'internal/db/statusfave.go')
-rw-r--r-- | internal/db/statusfave.go | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/internal/db/statusfave.go b/internal/db/statusfave.go index 98ff1d69d..37769ff79 100644 --- a/internal/db/statusfave.go +++ b/internal/db/statusfave.go @@ -26,23 +26,23 @@ import ( type StatusFave interface { // GetStatusFaveByAccountID gets one status fave created by the given // accountID, targeting the given statusID. - GetStatusFave(ctx context.Context, accountID string, statusID string) (*gtsmodel.StatusFave, Error) + GetStatusFave(ctx context.Context, accountID string, statusID string) (*gtsmodel.StatusFave, error) // GetStatusFave returns one status fave with the given id. - GetStatusFaveByID(ctx context.Context, id string) (*gtsmodel.StatusFave, Error) + GetStatusFaveByID(ctx context.Context, id string) (*gtsmodel.StatusFave, error) // GetStatusFaves returns a slice of faves/likes of the given status. // This slice will be unfiltered, not taking account of blocks and whatnot, so filter it before serving it back to a user. - GetStatusFavesForStatus(ctx context.Context, statusID string) ([]*gtsmodel.StatusFave, Error) + GetStatusFavesForStatus(ctx context.Context, statusID string) ([]*gtsmodel.StatusFave, error) // PopulateStatusFave ensures that all sub-models of a fave are populated (account, status, etc). PopulateStatusFave(ctx context.Context, statusFave *gtsmodel.StatusFave) error // PutStatusFave inserts the given statusFave into the database. - PutStatusFave(ctx context.Context, statusFave *gtsmodel.StatusFave) Error + PutStatusFave(ctx context.Context, statusFave *gtsmodel.StatusFave) error // DeleteStatusFave deletes one status fave with the given id. - DeleteStatusFaveByID(ctx context.Context, id string) Error + DeleteStatusFaveByID(ctx context.Context, id string) error // DeleteStatusFaves mass deletes status faves targeting targetAccountID // and/or originating from originAccountID and/or faving statusID. @@ -57,10 +57,10 @@ type StatusFave interface { // originate from originAccountID will be deleted. // // At least one parameter must not be an empty string. - DeleteStatusFaves(ctx context.Context, targetAccountID string, originAccountID string) Error + DeleteStatusFaves(ctx context.Context, targetAccountID string, originAccountID string) error // DeleteStatusFavesForStatus deletes all status faves that target the // given status ID. This is useful when a status has been deleted, and you need // to clean up after it. - DeleteStatusFavesForStatus(ctx context.Context, statusID string) Error + DeleteStatusFavesForStatus(ctx context.Context, statusID string) error } |