[chore] Refactor account deleting/block logic, tidy up some other processing things (#1599)

* start refactoring account deletion

* update to use state.DB

* further messing about

* some more tidying up

* more tidying, cleaning, nice-making

* further adventures in refactoring and the woes of technical debt

* update fr accept/reject

* poking + prodding

* fix up deleting

* create fave uri

* don't log using requestingAccount.ID because it might be nil

* move getBookmarks function

* use exists query to check for status bookmark

* use deletenotifications func

* fiddle

* delete follow request notif

* split up some db functions

* Fix possible nil pointer panic

* fix more possible nil pointers

* fix license headers

* warn when follow missing (target) account

* return wrapped err when bookmark/fave models can't be retrieved

* simplify self account delete

* warn log likely race condition

* de-sillify status delete loop

* move error check due north

* warn when unfollowSideEffects has no target account

* warn when no boost account is found

* warn + dump follow when no account

* more warnings

* warn on fave account not set

* move for loop inside anonymous function

* fix funky logic

* don't remove mutual account items on block;
do make sure unfollow occurs in both directions!

1 files changed, 25 insertions, 2 deletions

diff --git a/internal/db/notification.go b/internal/db/notification.go
index 19f0f199d..18e40b4c1 100644
--- a/internal/db/notification.go
+++ b/internal/db/notification.go
@@ -29,8 +29,31 @@ type Notification interface {
 	//
 	// Returned notifications will be ordered ID descending (ie., highest/newest to lowest/oldest).
 	GetNotifications(ctx context.Context, accountID string, excludeTypes []string, limit int, maxID string, sinceID string) ([]*gtsmodel.Notification, Error)
+
 	// GetNotification returns one notification according to its id.
 	GetNotification(ctx context.Context, id string) (*gtsmodel.Notification, Error)
-	// ClearNotifications deletes every notification that pertain to the given accountID.
-	ClearNotifications(ctx context.Context, accountID string) Error
+
+	// DeleteNotification deletes one notification according to its id,
+	// and removes that notification from the in-memory cache.
+	DeleteNotification(ctx context.Context, id string) Error
+
+	// DeleteNotifications mass deletes notifications targeting targetAccountID
+	// and/or originating from originAccountID.
+	//
+	// If targetAccountID is set and originAccountID isn't, all notifications
+	// that target the given account will be deleted.
+	//
+	// If originAccountID is set and targetAccountID isn't, all notifications
+	// originating from the given account will be deleted.
+	//
+	// If both are set, then notifications that target targetAccountID and
+	// originate from originAccountID will be deleted.
+	//
+	// At least one parameter must not be an empty string.
+	DeleteNotifications(ctx context.Context, targetAccountID string, originAccountID string) Error
+
+	// DeleteNotificationsForStatus deletes all notifications that relate to
+	// the given statusID. This function is useful when a status has been deleted,
+	// and so notifications relating to that status must also be deleted.
+	DeleteNotificationsForStatus(ctx context.Context, statusID string) Error
 }