[chore] update database caching library (#1040)

* convert most of the caches to use result.Cache{}

* add caching of emojis

* fix issues causing failing tests

* update go-cache/v2 instances with v3

* fix getnotification

* add a note about the left-in StatusCreate comment

* update EmojiCategory db access to use new result.Cache{}

* fix possible panic in getstatusparents

* further proof that kim is not stinky

1 files changed, 8 insertions, 9 deletions

diff --git a/internal/db/bundb/user_test.go b/internal/db/bundb/user_test.go
index 6ad59fc8e..18f67dde5 100644
--- a/internal/db/bundb/user_test.go
+++ b/internal/db/bundb/user_test.go
@@ -50,21 +50,20 @@ func (suite *UserTestSuite) TestGetUserByAccountID() {
 
 func (suite *UserTestSuite) TestUpdateUserSelectedColumns() {
 	testUser := suite.testUsers["local_account_1"]
-	user := &gtsmodel.User{
-		ID:     testUser.ID,
-		Email:  "whatever",
-		Locale: "es",
-	}
 
-	user, err := suite.db.UpdateUser(context.Background(), user, "email", "locale")
+	updateUser := new(gtsmodel.User)
+	*updateUser = *testUser
+	updateUser.Email = "whatever"
+	updateUser.Locale = "es"
+
+	err := suite.db.UpdateUser(context.Background(), updateUser)
 	suite.NoError(err)
-	suite.NotNil(user)
 
 	dbUser, err := suite.db.GetUserByID(context.Background(), testUser.ID)
 	suite.NoError(err)
 	suite.NotNil(dbUser)
-	suite.Equal("whatever", dbUser.Email)
-	suite.Equal("es", dbUser.Locale)
+	suite.Equal(updateUser.Email, dbUser.Email)
+	suite.Equal(updateUser.Locale, dbUser.Locale)
 	suite.Equal(testUser.AccountID, dbUser.AccountID)
 }