[feature] do not uncache status / emoji media if attached status is bookmarked (#2956)

* do not uncache status / emoji media if attached status is bookmarked

* add status bookmark and bookmark IDs caches

* update status bookmark tests

* move IsStatusBookmarkedBy() to StatusBookmark{} interface, rely on cache

* fix envparsing.sh test

3 files changed, 137 insertions, 83 deletions

diff --git a/internal/config/config.go b/internal/config/config.go
index a738dded4..f738ba797 100644
--- a/internal/config/config.go
+++ b/internal/config/config.go
@@ -191,48 +191,50 @@ type HTTPClientConfiguration struct {
 }
 
 type CacheConfiguration struct {
-	MemoryTarget             bytesize.Size `name:"memory-target"`
-	AccountMemRatio          float64       `name:"account-mem-ratio"`
-	AccountNoteMemRatio      float64       `name:"account-note-mem-ratio"`
-	AccountSettingsMemRatio  float64       `name:"account-settings-mem-ratio"`
-	AccountStatsMemRatio     float64       `name:"account-stats-mem-ratio"`
-	ApplicationMemRatio      float64       `name:"application-mem-ratio"`
-	BlockMemRatio            float64       `name:"block-mem-ratio"`
-	BlockIDsMemRatio         float64       `name:"block-mem-ratio"`
-	BoostOfIDsMemRatio       float64       `name:"boost-of-ids-mem-ratio"`
-	ClientMemRatio           float64       `name:"client-mem-ratio"`
-	EmojiMemRatio            float64       `name:"emoji-mem-ratio"`
-	EmojiCategoryMemRatio    float64       `name:"emoji-category-mem-ratio"`
-	FilterMemRatio           float64       `name:"filter-mem-ratio"`
-	FilterKeywordMemRatio    float64       `name:"filter-keyword-mem-ratio"`
-	FilterStatusMemRatio     float64       `name:"filter-status-mem-ratio"`
-	FollowMemRatio           float64       `name:"follow-mem-ratio"`
-	FollowIDsMemRatio        float64       `name:"follow-ids-mem-ratio"`
-	FollowRequestMemRatio    float64       `name:"follow-request-mem-ratio"`
-	FollowRequestIDsMemRatio float64       `name:"follow-request-ids-mem-ratio"`
-	InReplyToIDsMemRatio     float64       `name:"in-reply-to-ids-mem-ratio"`
-	InstanceMemRatio         float64       `name:"instance-mem-ratio"`
-	ListMemRatio             float64       `name:"list-mem-ratio"`
-	ListEntryMemRatio        float64       `name:"list-entry-mem-ratio"`
-	MarkerMemRatio           float64       `name:"marker-mem-ratio"`
-	MediaMemRatio            float64       `name:"media-mem-ratio"`
-	MentionMemRatio          float64       `name:"mention-mem-ratio"`
-	MoveMemRatio             float64       `name:"move-mem-ratio"`
-	NotificationMemRatio     float64       `name:"notification-mem-ratio"`
-	PollMemRatio             float64       `name:"poll-mem-ratio"`
-	PollVoteMemRatio         float64       `name:"poll-vote-mem-ratio"`
-	PollVoteIDsMemRatio      float64       `name:"poll-vote-ids-mem-ratio"`
-	ReportMemRatio           float64       `name:"report-mem-ratio"`
-	StatusMemRatio           float64       `name:"status-mem-ratio"`
-	StatusFaveMemRatio       float64       `name:"status-fave-mem-ratio"`
-	StatusFaveIDsMemRatio    float64       `name:"status-fave-ids-mem-ratio"`
-	TagMemRatio              float64       `name:"tag-mem-ratio"`
-	ThreadMuteMemRatio       float64       `name:"thread-mute-mem-ratio"`
-	TokenMemRatio            float64       `name:"token-mem-ratio"`
-	TombstoneMemRatio        float64       `name:"tombstone-mem-ratio"`
-	UserMemRatio             float64       `name:"user-mem-ratio"`
-	WebfingerMemRatio        float64       `name:"webfinger-mem-ratio"`
-	VisibilityMemRatio       float64       `name:"visibility-mem-ratio"`
+	MemoryTarget              bytesize.Size `name:"memory-target"`
+	AccountMemRatio           float64       `name:"account-mem-ratio"`
+	AccountNoteMemRatio       float64       `name:"account-note-mem-ratio"`
+	AccountSettingsMemRatio   float64       `name:"account-settings-mem-ratio"`
+	AccountStatsMemRatio      float64       `name:"account-stats-mem-ratio"`
+	ApplicationMemRatio       float64       `name:"application-mem-ratio"`
+	BlockMemRatio             float64       `name:"block-mem-ratio"`
+	BlockIDsMemRatio          float64       `name:"block-mem-ratio"`
+	BoostOfIDsMemRatio        float64       `name:"boost-of-ids-mem-ratio"`
+	ClientMemRatio            float64       `name:"client-mem-ratio"`
+	EmojiMemRatio             float64       `name:"emoji-mem-ratio"`
+	EmojiCategoryMemRatio     float64       `name:"emoji-category-mem-ratio"`
+	FilterMemRatio            float64       `name:"filter-mem-ratio"`
+	FilterKeywordMemRatio     float64       `name:"filter-keyword-mem-ratio"`
+	FilterStatusMemRatio      float64       `name:"filter-status-mem-ratio"`
+	FollowMemRatio            float64       `name:"follow-mem-ratio"`
+	FollowIDsMemRatio         float64       `name:"follow-ids-mem-ratio"`
+	FollowRequestMemRatio     float64       `name:"follow-request-mem-ratio"`
+	FollowRequestIDsMemRatio  float64       `name:"follow-request-ids-mem-ratio"`
+	InReplyToIDsMemRatio      float64       `name:"in-reply-to-ids-mem-ratio"`
+	InstanceMemRatio          float64       `name:"instance-mem-ratio"`
+	ListMemRatio              float64       `name:"list-mem-ratio"`
+	ListEntryMemRatio         float64       `name:"list-entry-mem-ratio"`
+	MarkerMemRatio            float64       `name:"marker-mem-ratio"`
+	MediaMemRatio             float64       `name:"media-mem-ratio"`
+	MentionMemRatio           float64       `name:"mention-mem-ratio"`
+	MoveMemRatio              float64       `name:"move-mem-ratio"`
+	NotificationMemRatio      float64       `name:"notification-mem-ratio"`
+	PollMemRatio              float64       `name:"poll-mem-ratio"`
+	PollVoteMemRatio          float64       `name:"poll-vote-mem-ratio"`
+	PollVoteIDsMemRatio       float64       `name:"poll-vote-ids-mem-ratio"`
+	ReportMemRatio            float64       `name:"report-mem-ratio"`
+	StatusMemRatio            float64       `name:"status-mem-ratio"`
+	StatusBookmarkMemRatio    float64       `name:"status-bookmark-mem-ratio"`
+	StatusBookmarkIDsMemRatio float64       `name:"status-bookmark-ids-mem-ratio"`
+	StatusFaveMemRatio        float64       `name:"status-fave-mem-ratio"`
+	StatusFaveIDsMemRatio     float64       `name:"status-fave-ids-mem-ratio"`
+	TagMemRatio               float64       `name:"tag-mem-ratio"`
+	ThreadMuteMemRatio        float64       `name:"thread-mute-mem-ratio"`
+	TokenMemRatio             float64       `name:"token-mem-ratio"`
+	TombstoneMemRatio         float64       `name:"tombstone-mem-ratio"`
+	UserMemRatio              float64       `name:"user-mem-ratio"`
+	WebfingerMemRatio         float64       `name:"webfinger-mem-ratio"`
+	VisibilityMemRatio        float64       `name:"visibility-mem-ratio"`
 }
 
 // MarshalMap will marshal current Configuration into a map structure (useful for JSON/TOML/YAML).
diff --git a/internal/config/defaults.go b/internal/config/defaults.go
index e84e619b8..3410dc5e4 100644
--- a/internal/config/defaults.go
+++ b/internal/config/defaults.go
@@ -156,47 +156,49 @@ var Defaults = Configuration{
 		// when TODO items in the size.go source
 		// file have been addressed, these should
 		// be able to make some more sense :D
-		AccountMemRatio:          5,
-		AccountNoteMemRatio:      1,
-		AccountSettingsMemRatio:  0.1,
-		AccountStatsMemRatio:     2,
-		ApplicationMemRatio:      0.1,
-		BlockMemRatio:            2,
-		BlockIDsMemRatio:         3,
-		BoostOfIDsMemRatio:       3,
-		ClientMemRatio:           0.1,
-		EmojiMemRatio:            3,
-		EmojiCategoryMemRatio:    0.1,
-		FilterMemRatio:           0.5,
-		FilterKeywordMemRatio:    0.5,
-		FilterStatusMemRatio:     0.5,
-		FollowMemRatio:           2,
-		FollowIDsMemRatio:        4,
-		FollowRequestMemRatio:    2,
-		FollowRequestIDsMemRatio: 2,
-		InReplyToIDsMemRatio:     3,
-		InstanceMemRatio:         1,
-		ListMemRatio:             1,
-		ListEntryMemRatio:        2,
-		MarkerMemRatio:           0.5,
-		MediaMemRatio:            4,
-		MentionMemRatio:          2,
-		MoveMemRatio:             0.1,
-		NotificationMemRatio:     2,
-		PollMemRatio:             1,
-		PollVoteMemRatio:         2,
-		PollVoteIDsMemRatio:      2,
-		ReportMemRatio:           1,
-		StatusMemRatio:           5,
-		StatusFaveMemRatio:       2,
-		StatusFaveIDsMemRatio:    3,
-		TagMemRatio:              2,
-		ThreadMuteMemRatio:       0.2,
-		TokenMemRatio:            0.75,
-		TombstoneMemRatio:        0.5,
-		UserMemRatio:             0.25,
-		WebfingerMemRatio:        0.1,
-		VisibilityMemRatio:       2,
+		AccountMemRatio:           5,
+		AccountNoteMemRatio:       1,
+		AccountSettingsMemRatio:   0.1,
+		AccountStatsMemRatio:      2,
+		ApplicationMemRatio:       0.1,
+		BlockMemRatio:             2,
+		BlockIDsMemRatio:          3,
+		BoostOfIDsMemRatio:        3,
+		ClientMemRatio:            0.1,
+		EmojiMemRatio:             3,
+		EmojiCategoryMemRatio:     0.1,
+		FilterMemRatio:            0.5,
+		FilterKeywordMemRatio:     0.5,
+		FilterStatusMemRatio:      0.5,
+		FollowMemRatio:            2,
+		FollowIDsMemRatio:         4,
+		FollowRequestMemRatio:     2,
+		FollowRequestIDsMemRatio:  2,
+		InReplyToIDsMemRatio:      3,
+		InstanceMemRatio:          1,
+		ListMemRatio:              1,
+		ListEntryMemRatio:         2,
+		MarkerMemRatio:            0.5,
+		MediaMemRatio:             4,
+		MentionMemRatio:           2,
+		MoveMemRatio:              0.1,
+		NotificationMemRatio:      2,
+		PollMemRatio:              1,
+		PollVoteMemRatio:          2,
+		PollVoteIDsMemRatio:       2,
+		ReportMemRatio:            1,
+		StatusMemRatio:            5,
+		StatusBookmarkMemRatio:    0.5,
+		StatusBookmarkIDsMemRatio: 2,
+		StatusFaveMemRatio:        2,
+		StatusFaveIDsMemRatio:     3,
+		TagMemRatio:               2,
+		ThreadMuteMemRatio:        0.2,
+		TokenMemRatio:             0.75,
+		TombstoneMemRatio:         0.5,
+		UserMemRatio:              0.25,
+		WebfingerMemRatio:         0.1,
+		VisibilityMemRatio:        2,
 	},
 
 	HTTPClient: HTTPClientConfiguration{
diff --git a/internal/config/helpers.gen.go b/internal/config/helpers.gen.go
index c986dd19d..2f37cbacb 100644
--- a/internal/config/helpers.gen.go
+++ b/internal/config/helpers.gen.go
@@ -3550,6 +3550,56 @@ func GetCacheStatusMemRatio() float64 { return global.GetCacheStatusMemRatio() }
 // SetCacheStatusMemRatio safely sets the value for global configuration 'Cache.StatusMemRatio' field
 func SetCacheStatusMemRatio(v float64) { global.SetCacheStatusMemRatio(v) }
 
+// GetCacheStatusBookmarkMemRatio safely fetches the Configuration value for state's 'Cache.StatusBookmarkMemRatio' field
+func (st *ConfigState) GetCacheStatusBookmarkMemRatio() (v float64) {
+	st.mutex.RLock()
+	v = st.config.Cache.StatusBookmarkMemRatio
+	st.mutex.RUnlock()
+	return
+}
+
+// SetCacheStatusBookmarkMemRatio safely sets the Configuration value for state's 'Cache.StatusBookmarkMemRatio' field
+func (st *ConfigState) SetCacheStatusBookmarkMemRatio(v float64) {
+	st.mutex.Lock()
+	defer st.mutex.Unlock()
+	st.config.Cache.StatusBookmarkMemRatio = v
+	st.reloadToViper()
+}
+
+// CacheStatusBookmarkMemRatioFlag returns the flag name for the 'Cache.StatusBookmarkMemRatio' field
+func CacheStatusBookmarkMemRatioFlag() string { return "cache-status-bookmark-mem-ratio" }
+
+// GetCacheStatusBookmarkMemRatio safely fetches the value for global configuration 'Cache.StatusBookmarkMemRatio' field
+func GetCacheStatusBookmarkMemRatio() float64 { return global.GetCacheStatusBookmarkMemRatio() }
+
+// SetCacheStatusBookmarkMemRatio safely sets the value for global configuration 'Cache.StatusBookmarkMemRatio' field
+func SetCacheStatusBookmarkMemRatio(v float64) { global.SetCacheStatusBookmarkMemRatio(v) }
+
+// GetCacheStatusBookmarkIDsMemRatio safely fetches the Configuration value for state's 'Cache.StatusBookmarkIDsMemRatio' field
+func (st *ConfigState) GetCacheStatusBookmarkIDsMemRatio() (v float64) {
+	st.mutex.RLock()
+	v = st.config.Cache.StatusBookmarkIDsMemRatio
+	st.mutex.RUnlock()
+	return
+}
+
+// SetCacheStatusBookmarkIDsMemRatio safely sets the Configuration value for state's 'Cache.StatusBookmarkIDsMemRatio' field
+func (st *ConfigState) SetCacheStatusBookmarkIDsMemRatio(v float64) {
+	st.mutex.Lock()
+	defer st.mutex.Unlock()
+	st.config.Cache.StatusBookmarkIDsMemRatio = v
+	st.reloadToViper()
+}
+
+// CacheStatusBookmarkIDsMemRatioFlag returns the flag name for the 'Cache.StatusBookmarkIDsMemRatio' field
+func CacheStatusBookmarkIDsMemRatioFlag() string { return "cache-status-bookmark-ids-mem-ratio" }
+
+// GetCacheStatusBookmarkIDsMemRatio safely fetches the value for global configuration 'Cache.StatusBookmarkIDsMemRatio' field
+func GetCacheStatusBookmarkIDsMemRatio() float64 { return global.GetCacheStatusBookmarkIDsMemRatio() }
+
+// SetCacheStatusBookmarkIDsMemRatio safely sets the value for global configuration 'Cache.StatusBookmarkIDsMemRatio' field
+func SetCacheStatusBookmarkIDsMemRatio(v float64) { global.SetCacheStatusBookmarkIDsMemRatio(v) }
+
 // GetCacheStatusFaveMemRatio safely fetches the Configuration value for state's 'Cache.StatusFaveMemRatio' field
 func (st *ConfigState) GetCacheStatusFaveMemRatio() (v float64) {
 	st.mutex.RLock()