diff options
author | 2024-09-16 16:46:09 +0000 | |
---|---|---|
committer | 2024-09-16 16:46:09 +0000 | |
commit | 84279f6a6a0201c90a6747fe8b82c38d5b4e49e2 (patch) | |
tree | 6c777c7ed4888d990533117d7e63376bcc23a3fb /internal/cache/size.go | |
parent | [chore] Refactor federatingDB.Undo, avoid 500 errors on Undo Like (#3310) (diff) | |
download | gotosocial-84279f6a6a0201c90a6747fe8b82c38d5b4e49e2.tar.xz |
[performance] cache more database calls, reduce required database calls overall (#3290)
* improvements to caching for lists and relationship to accounts / follows
* fix nil panic in AddToList()
* ensure list related caches are correctly invalidated
* ensure returned ID lists are ordered correctly
* bump go-structr to v0.8.9 (returns early if zero uncached keys to be loaded)
* remove zero checks in uncached key load functions (go-structr now handles this)
* fix issues after rebase on upstream/main
* update the expected return order of CSV exports (since list entries are now down by entry creation date)
* rename some funcs, allow deleting list entries for multiple follow IDs at a time, fix up more tests
* use returning statements on delete to get cache invalidation info
* fixes to recent database delete changes
* fix broken list entries delete sql
* remove unused db function
* update remainder of delete functions to behave in similar way, some other small tweaks
* fix delete user sql, allow returning on err no entries
* uncomment + fix list database tests
* update remaining list tests
* update envparsing test
* add comments to each specific key being invalidated
* add more cache invalidation explanatory comments
* whoops; actually delete poll votes from database in the DeletePollByID() func
* remove added but-commented-out field
* improved comment regarding paging being disabled
* make cache invalidation comments match what's actually happening
* fix up delete query comments to match what is happening
* rename function to read a bit better
* don't use ErrNoEntries on delete when not needed (it's only needed for a RETURNING call)
* update function name in test
* move list exclusivity check to AFTER eligibility check. use log.Panic() instead of panic()
* use the poll_id column in poll_votes for selecting votes in poll ID
* fix function name
Diffstat (limited to 'internal/cache/size.go')
-rw-r--r-- | internal/cache/size.go | 21 |
1 files changed, 9 insertions, 12 deletions
diff --git a/internal/cache/size.go b/internal/cache/size.go index 49c2f4318..8367e4c46 100644 --- a/internal/cache/size.go +++ b/internal/cache/size.go @@ -166,6 +166,7 @@ func calculateCacheMax(keySz, valSz uintptr, ratio float64) int { // totalOfRatios returns the total of all cache ratios added together. func totalOfRatios() float64 { + // NOTE: this is not performant calculating // this every damn time (mainly the mutex unlocks // required to access each config var). fortunately @@ -189,11 +190,13 @@ func totalOfRatios() float64 { config.GetCacheFollowIDsMemRatio() + config.GetCacheFollowRequestMemRatio() + config.GetCacheFollowRequestIDsMemRatio() + + config.GetCacheFollowingTagIDsMemRatio() + + config.GetCacheInReplyToIDsMemRatio() + config.GetCacheInstanceMemRatio() + config.GetCacheInteractionRequestMemRatio() + - config.GetCacheInReplyToIDsMemRatio() + config.GetCacheListMemRatio() + - config.GetCacheListEntryMemRatio() + + config.GetCacheListIDsMemRatio() + + config.GetCacheListedIDsMemRatio() + config.GetCacheMarkerMemRatio() + config.GetCacheMediaMemRatio() + config.GetCacheMentionMemRatio() + @@ -201,7 +204,9 @@ func totalOfRatios() float64 { config.GetCacheNotificationMemRatio() + config.GetCachePollMemRatio() + config.GetCachePollVoteMemRatio() + + config.GetCachePollVoteIDsMemRatio() + config.GetCacheReportMemRatio() + + config.GetCacheSinBinStatusMemRatio() + config.GetCacheStatusMemRatio() + config.GetCacheStatusBookmarkMemRatio() + config.GetCacheStatusBookmarkIDsMemRatio() + @@ -212,6 +217,8 @@ func totalOfRatios() float64 { config.GetCacheTokenMemRatio() + config.GetCacheTombstoneMemRatio() + config.GetCacheUserMemRatio() + + config.GetCacheUserMuteMemRatio() + + config.GetCacheUserMuteIDsMemRatio() + config.GetCacheWebfingerMemRatio() + config.GetCacheVisibilityMemRatio() } @@ -466,16 +473,6 @@ func sizeofList() uintptr { })) } -func sizeofListEntry() uintptr { - return uintptr(size.Of(>smodel.ListEntry{ - ID: exampleID, - CreatedAt: exampleTime, - UpdatedAt: exampleTime, - ListID: exampleID, - FollowID: exampleID, - })) -} - func sizeofMarker() uintptr { return uintptr(size.Of(>smodel.Marker{ AccountID: exampleID, |