summaryrefslogtreecommitdiff
path: root/internal/api
diff options
context:
space:
mode:
authorLibravatar tobi <31960611+tsmethurst@users.noreply.github.com>2024-06-18 18:18:35 +0200
committerLibravatar GitHub <noreply@github.com>2024-06-18 18:18:35 +0200
commit4ce5c37df5b69b09c6759ef751eb39a8bc839094 (patch)
tree76974b8d501623ceb2059276eeeb02a62371b2e3 /internal/api
parent[feature/frontend] Reports frontend v2 (#3022) (diff)
downloadgotosocial-4ce5c37df5b69b09c6759ef751eb39a8bc839094.tar.xz
[bugfix] rename `include_types[]` to `types[]` (#3023)
Diffstat (limited to 'internal/api')
-rw-r--r--internal/api/client/notifications/notifications.go4
-rw-r--r--internal/api/client/notifications/notificationsget.go2
-rw-r--r--internal/api/client/notifications/notificationsget_test.go18
3 files changed, 12 insertions, 12 deletions
diff --git a/internal/api/client/notifications/notifications.go b/internal/api/client/notifications/notifications.go
index ab015427e..cb1edf3ff 100644
--- a/internal/api/client/notifications/notifications.go
+++ b/internal/api/client/notifications/notifications.go
@@ -34,8 +34,8 @@ const (
BasePathWithID = BasePath + "/:" + IDKey
BasePathWithClear = BasePath + "/clear"
- // IncludeTypesKey names an array param specifying notification types to include.
- IncludeTypesKey = "include_types[]"
+ // TypesKey names an array param specifying notification types to include.
+ TypesKey = "types[]"
// ExcludeTypesKey names an array param specifying notification types to exclude.
ExcludeTypesKey = "exclude_types[]"
MaxIDKey = "max_id"
diff --git a/internal/api/client/notifications/notificationsget.go b/internal/api/client/notifications/notificationsget.go
index 533932d11..f7bcf1994 100644
--- a/internal/api/client/notifications/notificationsget.go
+++ b/internal/api/client/notifications/notificationsget.go
@@ -171,7 +171,7 @@ func (m *Module) NotificationsGETHandler(c *gin.Context) {
c.Query(SinceIDKey),
c.Query(MinIDKey),
limit,
- c.QueryArray(IncludeTypesKey),
+ c.QueryArray(TypesKey),
c.QueryArray(ExcludeTypesKey),
)
if errWithCode != nil {
diff --git a/internal/api/client/notifications/notificationsget_test.go b/internal/api/client/notifications/notificationsget_test.go
index 118303cae..97d0e854b 100644
--- a/internal/api/client/notifications/notificationsget_test.go
+++ b/internal/api/client/notifications/notificationsget_test.go
@@ -45,7 +45,7 @@ func (suite *NotificationsTestSuite) getNotifications(
maxID string,
minID string,
limit int,
- includeTypes []string,
+ types []string,
excludeTypes []string,
expectedHTTPStatus int,
expectedBody string,
@@ -71,8 +71,8 @@ func (suite *NotificationsTestSuite) getNotifications(
if limit != 0 {
query.Set(notifications.LimitKey, strconv.Itoa(limit))
}
- if len(includeTypes) > 0 {
- query[notifications.IncludeTypesKey] = includeTypes
+ if len(types) > 0 {
+ query[notifications.TypesKey] = types
}
if len(excludeTypes) > 0 {
query[notifications.ExcludeTypesKey] = excludeTypes
@@ -123,7 +123,7 @@ func (suite *NotificationsTestSuite) TestGetNotificationsSingle() {
maxID := ""
minID := ""
limit := 10
- includeTypes := []string(nil)
+ types := []string(nil)
excludeTypes := []string(nil)
expectedHTTPStatus := http.StatusOK
expectedBody := ""
@@ -135,7 +135,7 @@ func (suite *NotificationsTestSuite) TestGetNotificationsSingle() {
maxID,
minID,
limit,
- includeTypes,
+ types,
excludeTypes,
expectedHTTPStatus,
expectedBody,
@@ -181,7 +181,7 @@ func (suite *NotificationsTestSuite) TestGetNotificationsExcludeOneType() {
maxID := ""
minID := ""
limit := 10
- includeTypes := []string(nil)
+ types := []string(nil)
excludeTypes := []string{"follow_request"}
expectedHTTPStatus := http.StatusOK
expectedBody := ""
@@ -193,7 +193,7 @@ func (suite *NotificationsTestSuite) TestGetNotificationsExcludeOneType() {
maxID,
minID,
limit,
- includeTypes,
+ types,
excludeTypes,
expectedHTTPStatus,
expectedBody,
@@ -220,7 +220,7 @@ func (suite *NotificationsTestSuite) TestGetNotificationsIncludeOneType() {
maxID := ""
minID := ""
limit := 10
- includeTypes := []string{"favourite"}
+ types := []string{"favourite"}
excludeTypes := []string(nil)
expectedHTTPStatus := http.StatusOK
expectedBody := ""
@@ -232,7 +232,7 @@ func (suite *NotificationsTestSuite) TestGetNotificationsIncludeOneType() {
maxID,
minID,
limit,
- includeTypes,
+ types,
excludeTypes,
expectedHTTPStatus,
expectedBody,