[chore] use our own logging implementation (#716)

* first commit

Signed-off-by: kim <grufwub@gmail.com>

* replace logging with our own log library

Signed-off-by: kim <grufwub@gmail.com>

* fix imports

Signed-off-by: kim <grufwub@gmail.com>

* fix log imports

Signed-off-by: kim <grufwub@gmail.com>

* add license text

Signed-off-by: kim <grufwub@gmail.com>

* fix package import cycle between config and log package

Signed-off-by: kim <grufwub@gmail.com>

* fix empty kv.Fields{} being passed to WithFields()

Signed-off-by: kim <grufwub@gmail.com>

* fix uses of log.WithFields() with whitespace issues and empty slices

Signed-off-by: kim <grufwub@gmail.com>

* *linter related grumbling*

Signed-off-by: kim <grufwub@gmail.com>

* gofmt the codebase! also fix more log.WithFields() formatting issues

Signed-off-by: kim <grufwub@gmail.com>

* update testrig code to match new changes

Signed-off-by: kim <grufwub@gmail.com>

* fix error wrapping in non fmt.Errorf function

Signed-off-by: kim <grufwub@gmail.com>

* add benchmarking of log.Caller() vs non-cached

Signed-off-by: kim <grufwub@gmail.com>

* fix syslog tests, add standard build tags to test runner to ensure consistency

Signed-off-by: kim <grufwub@gmail.com>

* make syslog tests more robust

Signed-off-by: kim <grufwub@gmail.com>

* fix caller depth arithmatic (is that how you spell it?)

Signed-off-by: kim <grufwub@gmail.com>

* update to use unkeyed fields in kv.Field{} instances

Signed-off-by: kim <grufwub@gmail.com>

* update go-kv library

Signed-off-by: kim <grufwub@gmail.com>

* update libraries list

Signed-off-by: kim <grufwub@gmail.com>

* fuck you linter get nerfed

Signed-off-by: kim <grufwub@gmail.com>

Co-authored-by: tobi <31960611+tsmethurst@users.noreply.github.com>

2 files changed, 17 insertions, 20 deletions

diff --git a/internal/api/security/signaturecheck.go b/internal/api/security/signaturecheck.go
index 1dd6b5f79..1c117cd1b 100644
--- a/internal/api/security/signaturecheck.go
+++ b/internal/api/security/signaturecheck.go
@@ -4,8 +4,8 @@ import (
 	"net/http"
 	"net/url"
 
-	"github.com/sirupsen/logrus"
 	"github.com/superseriousbusiness/gotosocial/internal/ap"
+	"github.com/superseriousbusiness/gotosocial/internal/log"
 
 	"github.com/gin-gonic/gin"
 	"github.com/go-fed/httpsig"
@@ -15,8 +15,6 @@ import (
 // that signed the request is permitted to access the server. If it is permitted, the handler will set the key
 // verifier and the signature in the gin context for use down the line.
 func (m *Module) SignatureCheck(c *gin.Context) {
-	l := logrus.WithField("func", "DomainBlockChecker")
-
 	// create the verifier from the request
 	// if the request is signed, it will have a signature header
 	verifier, err := httpsig.NewVerifier(c.Request)
@@ -32,12 +30,12 @@ func (m *Module) SignatureCheck(c *gin.Context) {
 			// if the domain is blocked we want to bail as early as possible
 			blocked, err := m.db.IsURIBlocked(c.Request.Context(), requestingPublicKeyID)
 			if err != nil {
-				l.Errorf("could not tell if domain %s was blocked or not: %s", requestingPublicKeyID.Host, err)
+				log.Errorf("could not tell if domain %s was blocked or not: %s", requestingPublicKeyID.Host, err)
 				c.AbortWithStatus(http.StatusInternalServerError)
 				return
 			}
 			if blocked {
-				l.Infof("domain %s is blocked", requestingPublicKeyID.Host)
+				log.Infof("domain %s is blocked", requestingPublicKeyID.Host)
 				c.AbortWithStatus(http.StatusForbidden)
 				return
 			}
diff --git a/internal/api/security/tokencheck.go b/internal/api/security/tokencheck.go
index e366af2ea..0e9e7bde2 100644
--- a/internal/api/security/tokencheck.go
+++ b/internal/api/security/tokencheck.go
@@ -20,9 +20,9 @@ package security
 
 import (
 	"github.com/gin-gonic/gin"
-	"github.com/sirupsen/logrus"
 	"github.com/superseriousbusiness/gotosocial/internal/db"
 	"github.com/superseriousbusiness/gotosocial/internal/gtsmodel"
+	"github.com/superseriousbusiness/gotosocial/internal/log"
 	"github.com/superseriousbusiness/gotosocial/internal/oauth"
 )
 
@@ -32,7 +32,6 @@ import (
 // If user or account can't be found, then the handler won't *fail*, in case the server wants to allow
 // public requests that don't have a Bearer token set (eg., for public instance information and so on).
 func (m *Module) TokenCheck(c *gin.Context) {
-	l := logrus.WithField("func", "OauthTokenMiddleware")
 	ctx := c.Request.Context()
 	defer c.Next()
 
@@ -43,38 +42,38 @@ func (m *Module) TokenCheck(c *gin.Context) {
 
 	ti, err := m.server.ValidationBearerToken(c.Copy().Request)
 	if err != nil {
-		l.Infof("token was passed in Authorization header but we could not validate it: %s", err)
+		log.Infof("token was passed in Authorization header but we could not validate it: %s", err)
 		return
 	}
 	c.Set(oauth.SessionAuthorizedToken, ti)
 
 	// check for user-level token
 	if userID := ti.GetUserID(); userID != "" {
-		l.Tracef("authenticated user %s with bearer token, scope is %s", userID, ti.GetScope())
+		log.Tracef("authenticated user %s with bearer token, scope is %s", userID, ti.GetScope())
 
 		// fetch user for this token
 		user := &gtsmodel.User{}
 		if err := m.db.GetByID(ctx, userID, user); err != nil {
 			if err != db.ErrNoEntries {
-				l.Errorf("database error looking for user with id %s: %s", userID, err)
+				log.Errorf("database error looking for user with id %s: %s", userID, err)
 				return
 			}
-			l.Warnf("no user found for userID %s", userID)
+			log.Warnf("no user found for userID %s", userID)
 			return
 		}
 
 		if user.ConfirmedAt.IsZero() {
-			l.Warnf("authenticated user %s has never confirmed thier email address", userID)
+			log.Warnf("authenticated user %s has never confirmed thier email address", userID)
 			return
 		}
 
 		if !user.Approved {
-			l.Warnf("authenticated user %s's account was never approved by an admin", userID)
+			log.Warnf("authenticated user %s's account was never approved by an admin", userID)
 			return
 		}
 
 		if user.Disabled {
-			l.Warnf("authenticated user %s's account was disabled'", userID)
+			log.Warnf("authenticated user %s's account was disabled'", userID)
 			return
 		}
 
@@ -84,15 +83,15 @@ func (m *Module) TokenCheck(c *gin.Context) {
 		acct, err := m.db.GetAccountByID(ctx, user.AccountID)
 		if err != nil {
 			if err != db.ErrNoEntries {
-				l.Errorf("database error looking for account with id %s: %s", user.AccountID, err)
+				log.Errorf("database error looking for account with id %s: %s", user.AccountID, err)
 				return
 			}
-			l.Warnf("no account found for userID %s", userID)
+			log.Warnf("no account found for userID %s", userID)
 			return
 		}
 
 		if !acct.SuspendedAt.IsZero() {
-			l.Warnf("authenticated user %s's account (accountId=%s) has been suspended", userID, user.AccountID)
+			log.Warnf("authenticated user %s's account (accountId=%s) has been suspended", userID, user.AccountID)
 			return
 		}
 
@@ -101,16 +100,16 @@ func (m *Module) TokenCheck(c *gin.Context) {
 
 	// check for application token
 	if clientID := ti.GetClientID(); clientID != "" {
-		l.Tracef("authenticated client %s with bearer token, scope is %s", clientID, ti.GetScope())
+		log.Tracef("authenticated client %s with bearer token, scope is %s", clientID, ti.GetScope())
 
 		// fetch app for this token
 		app := &gtsmodel.Application{}
 		if err := m.db.GetWhere(ctx, []db.Where{{Key: "client_id", Value: clientID}}, app); err != nil {
 			if err != db.ErrNoEntries {
-				l.Errorf("database error looking for application with clientID %s: %s", clientID, err)
+				log.Errorf("database error looking for application with clientID %s: %s", clientID, err)
 				return
 			}
-			l.Warnf("no app found for client %s", clientID)
+			log.Warnf("no app found for client %s", clientID)
 			return
 		}
 		c.Set(oauth.SessionAuthorizedApplication, app)