[chore] The Big Middleware and API Refactor (tm) (#1250)

* interim commit: start refactoring middlewares into package under router

* another interim commit, this is becoming a big job

* another fucking massive interim commit

* refactor bookmarks to new style

* ambassador, wiz zeze commits you are spoiling uz

* she compiles, we're getting there

* we're just normal men; we're just innocent men

* apiutil

* whoopsie

* i'm glad noone reads commit msgs haha :blob_sweat:

* use that weirdo go-bytesize library for maxMultipartMemory

* fix media module paths

1 files changed, 0 insertions, 177 deletions

diff --git a/internal/api/s2s/user/userget_test.go b/internal/api/s2s/user/userget_test.go
deleted file mode 100644
index c656911d7..000000000
--- a/internal/api/s2s/user/userget_test.go
+++ /dev/null
@@ -1,177 +0,0 @@
-/*
-   GoToSocial
-   Copyright (C) 2021-2022 GoToSocial Authors admin@gotosocial.org
-
-   This program is free software: you can redistribute it and/or modify
-   it under the terms of the GNU Affero General Public License as published by
-   the Free Software Foundation, either version 3 of the License, or
-   (at your option) any later version.
-
-   This program is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-   GNU Affero General Public License for more details.
-
-   You should have received a copy of the GNU Affero General Public License
-   along with this program.  If not, see <http://www.gnu.org/licenses/>.
-*/
-
-package user_test
-
-import (
-	"context"
-	"encoding/json"
-	"io/ioutil"
-	"net/http"
-	"net/http/httptest"
-	"testing"
-
-	"github.com/gin-gonic/gin"
-	"github.com/stretchr/testify/suite"
-	"github.com/superseriousbusiness/activity/streams"
-	"github.com/superseriousbusiness/activity/streams/vocab"
-	apimodel "github.com/superseriousbusiness/gotosocial/internal/api/model"
-	"github.com/superseriousbusiness/gotosocial/internal/api/s2s/user"
-	"github.com/superseriousbusiness/gotosocial/internal/oauth"
-	"github.com/superseriousbusiness/gotosocial/testrig"
-)
-
-type UserGetTestSuite struct {
-	UserStandardTestSuite
-}
-
-func (suite *UserGetTestSuite) TestGetUser() {
-	// the dereference we're gonna use
-	derefRequests := testrig.NewTestDereferenceRequests(suite.testAccounts)
-	signedRequest := derefRequests["foss_satan_dereference_zork"]
-	targetAccount := suite.testAccounts["local_account_1"]
-
-	// setup request
-	recorder := httptest.NewRecorder()
-	ctx, _ := testrig.CreateGinTestContext(recorder, nil)
-	ctx.Request = httptest.NewRequest(http.MethodGet, targetAccount.URI, nil) // the endpoint we're hitting
-	ctx.Request.Header.Set("accept", "application/activity+json")
-	ctx.Request.Header.Set("Signature", signedRequest.SignatureHeader)
-	ctx.Request.Header.Set("Date", signedRequest.DateHeader)
-
-	// we need to pass the context through signature check first to set appropriate values on it
-	suite.securityModule.SignatureCheck(ctx)
-
-	// normally the router would populate these params from the path values,
-	// but because we're calling the function directly, we need to set them manually.
-	ctx.Params = gin.Params{
-		gin.Param{
-			Key:   user.UsernameKey,
-			Value: targetAccount.Username,
-		},
-	}
-
-	// trigger the function being tested
-	suite.userModule.UsersGETHandler(ctx)
-
-	// check response
-	suite.EqualValues(http.StatusOK, recorder.Code)
-
-	result := recorder.Result()
-	defer result.Body.Close()
-	b, err := ioutil.ReadAll(result.Body)
-	suite.NoError(err)
-
-	// should be a Person
-	m := make(map[string]interface{})
-	err = json.Unmarshal(b, &m)
-	suite.NoError(err)
-
-	t, err := streams.ToType(context.Background(), m)
-	suite.NoError(err)
-
-	person, ok := t.(vocab.ActivityStreamsPerson)
-	suite.True(ok)
-
-	// convert person to account
-	// since this account is already known, we should get a pretty full model of it from the conversion
-	a, err := suite.tc.ASRepresentationToAccount(context.Background(), person, "", false)
-	suite.NoError(err)
-	suite.EqualValues(targetAccount.Username, a.Username)
-}
-
-// TestGetUserPublicKeyDeleted checks whether the public key of a deleted account can still be dereferenced.
-// This is needed by remote instances for authenticating delete requests and stuff like that.
-func (suite *UserGetTestSuite) TestGetUserPublicKeyDeleted() {
-	userModule := user.New(suite.processor).(*user.Module)
-	targetAccount := suite.testAccounts["local_account_1"]
-
-	// first delete the account, as though zork had deleted himself
-	authed := &oauth.Auth{
-		Application: suite.testApplications["local_account_1"],
-		User:        suite.testUsers["local_account_1"],
-		Account:     suite.testAccounts["local_account_1"],
-	}
-	suite.processor.AccountDeleteLocal(context.Background(), authed, &apimodel.AccountDeleteRequest{
-		Password:       "password",
-		DeleteOriginID: targetAccount.ID,
-	})
-
-	// wait for the account delete to be processed
-	if !testrig.WaitFor(func() bool {
-		a, _ := suite.db.GetAccountByID(context.Background(), targetAccount.ID)
-		return !a.SuspendedAt.IsZero()
-	}) {
-		suite.FailNow("delete of account timed out")
-	}
-
-	// the dereference we're gonna use
-	derefRequests := testrig.NewTestDereferenceRequests(suite.testAccounts)
-	signedRequest := derefRequests["foss_satan_dereference_zork_public_key"]
-
-	// setup request
-	recorder := httptest.NewRecorder()
-	ctx, _ := testrig.CreateGinTestContext(recorder, nil)
-	ctx.Request = httptest.NewRequest(http.MethodGet, targetAccount.PublicKeyURI, nil) // the endpoint we're hitting
-	ctx.Request.Header.Set("accept", "application/activity+json")
-	ctx.Request.Header.Set("Signature", signedRequest.SignatureHeader)
-	ctx.Request.Header.Set("Date", signedRequest.DateHeader)
-
-	// we need to pass the context through signature check first to set appropriate values on it
-	suite.securityModule.SignatureCheck(ctx)
-
-	// normally the router would populate these params from the path values,
-	// but because we're calling the function directly, we need to set them manually.
-	ctx.Params = gin.Params{
-		gin.Param{
-			Key:   user.UsernameKey,
-			Value: targetAccount.Username,
-		},
-	}
-
-	// trigger the function being tested
-	userModule.UsersGETHandler(ctx)
-
-	// check response
-	suite.EqualValues(http.StatusOK, recorder.Code)
-
-	result := recorder.Result()
-	defer result.Body.Close()
-	b, err := ioutil.ReadAll(result.Body)
-	suite.NoError(err)
-
-	// should be a Person
-	m := make(map[string]interface{})
-	err = json.Unmarshal(b, &m)
-	suite.NoError(err)
-
-	t, err := streams.ToType(context.Background(), m)
-	suite.NoError(err)
-
-	person, ok := t.(vocab.ActivityStreamsPerson)
-	suite.True(ok)
-
-	// convert person to account
-	a, err := suite.tc.ASRepresentationToAccount(context.Background(), person, "", false)
-	suite.NoError(err)
-	suite.EqualValues(targetAccount.Username, a.Username)
-}
-
-func TestUserGetTestSuite(t *testing.T) {
-	suite.Run(t, new(UserGetTestSuite))
-}