diff options
| author |  tobi <31960611+tsmethurst@users.noreply.github.com> | 2022-09-17 19:12:12 +0200 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2022-09-17 19:12:12 +0200 |
| commit | c1585d5f8a57256a330aae4a322468aaccf9d3fa (patch) | |
| tree | f31dec55572d068f1bee8615f5ccda7454d762f9 /internal/api/errorhandling.go | |
| parent | [bugfix] Fix emojis, attachments, and mentions not being serialized correctly... (diff) | |
| download | gotosocial-c1585d5f8a57256a330aae4a322468aaccf9d3fa.tar.xz | |
[bugfix] Fix domains not being unblockable, log internal server errors from API (#833)
* log internal server errors from 500 api calls
* don't exec into nil dest
* don't exec into nil dest
* log error in router logger not api errorhandling
* update logging a tad
* linter
Diffstat (limited to 'internal/api/errorhandling.go')
| -rw-r--r-- | internal/api/errorhandling.go | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/internal/api/errorhandling.go b/internal/api/errorhandling.go index 346841f3f..f6fec4168 100644 --- a/internal/api/errorhandling.go +++ b/internal/api/errorhandling.go @@ -86,6 +86,10 @@ func genericErrorHandler(c *gin.Context, instanceGet func(ctx context.Context, d // if something goes wrong during the function, it will recover and just try to serve // an appropriate application/json content-type error. func ErrorHandler(c *gin.Context, errWithCode gtserror.WithCode, instanceGet func(ctx context.Context, domain string) (*apimodel.Instance, gtserror.WithCode)) { + // set the error on the gin context so that it can be logged + // in the gin logger middleware (internal/router/logger.go) + c.Error(errWithCode) //nolint:errcheck + // discover if we're allowed to serve a nice html error page, // or if we should just use a json. Normally we would want to // check for a returned error, but if an error occurs here we |