summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLibravatar nicole mikołajczyk <git@mkljczk.pl>2025-06-10 12:16:09 +0200
committerLibravatar tobi <kipvandenbos@noreply.codeberg.org>2025-06-10 12:16:09 +0200
commitd3f2c2c7654a8b3bb2841e9598db55c1275c23f6 (patch)
tree31800ca01bd0c4932d28ccb3e3d8519a2386e1d0
parent[docs] update `protocol` arg help text to reflect documentation (#4250) (diff)
downloadgotosocial-d3f2c2c7654a8b3bb2841e9598db55c1275c23f6.tar.xz
[bugfix] fix existing statuses with invalid visibility (#4253)
Signed-off-by: nicole mikołajczyk <git@mkljczk.pl> # Description Related to #4252. This fixes existing statuses with visibility enum set to 0, if any exist on the server, by replacing their visibility to direct (to not leak them outside the intended scope). ## Checklist Please put an x inside each checkbox to indicate that you've read and followed it: `[ ]` -> `[x]` If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want). - [x] I/we have read the [GoToSocial contribution guidelines](https://codeberg.org/superseriousbusiness/gotosocial/src/branch/main/CONTRIBUTING.md). - [ ] I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat. - [x] I/we have not leveraged AI to create the proposed changes. - [x] I/we have performed a self-review of added code. - [x] I/we have written code that is legible and maintainable by others. - [x] I/we have commented the added code, particularly in hard-to-understand areas. - [ ] I/we have made any necessary changes to documentation. - [ ] I/we have added tests that cover new code. - [ ] I/we have run tests and they pass locally with the changes. - [x] I/we have run `go fmt ./...` and `golangci-lint run`. Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4253 Co-authored-by: nicole mikołajczyk <git@mkljczk.pl> Co-committed-by: nicole mikołajczyk <git@mkljczk.pl>
-rw-r--r--internal/db/bundb/migrations/20250608213700_invalid_status_visibility_fix.go52
1 files changed, 52 insertions, 0 deletions
diff --git a/internal/db/bundb/migrations/20250608213700_invalid_status_visibility_fix.go b/internal/db/bundb/migrations/20250608213700_invalid_status_visibility_fix.go
new file mode 100644
index 000000000..85e9d050e
--- /dev/null
+++ b/internal/db/bundb/migrations/20250608213700_invalid_status_visibility_fix.go
@@ -0,0 +1,52 @@
+// GoToSocial
+// Copyright (C) GoToSocial Authors admin@gotosocial.org
+// SPDX-License-Identifier: AGPL-3.0-or-later
+//
+// This program is free software: you can redistribute it and/or modify
+// it under the terms of the GNU Affero General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU Affero General Public License for more details.
+//
+// You should have received a copy of the GNU Affero General Public License
+// along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+package migrations
+
+import (
+ "context"
+
+ "code.superseriousbusiness.org/gotosocial/internal/gtsmodel"
+ "github.com/uptrace/bun"
+)
+
+func init() {
+ up := func(ctx context.Context, db *bun.DB) error {
+ // Replace visibility for invalid statuses with direct.
+ if _, err := db.
+ NewUpdate().
+ Table("statuses").
+ Column("visibility").
+ Set("? = ?", bun.Ident("visibility"), gtsmodel.VisibilityDirect).
+ Where("? = ?", bun.Ident("visibility"), 0).
+ Exec(ctx); err != nil {
+ return err
+ }
+
+ return nil
+ }
+
+ down := func(ctx context.Context, db *bun.DB) error {
+ return db.RunInTx(ctx, nil, func(ctx context.Context, tx bun.Tx) error {
+ return nil
+ })
+ }
+
+ if err := Migrations.Register(up, down); err != nil {
+ panic(err)
+ }
+}