From 554544276a604c144df45efcb060c80aa322088c Mon Sep 17 00:00:00 2001 From: Denton Liu Date: Mon, 29 Apr 2019 04:28:14 -0400 Subject: *.[ch]: remove extern from function declarations using spatch There has been a push to remove extern from function declarations. Remove some instances of "extern" for function declarations which are caught by Coccinelle. Note that Coccinelle has some difficulty with processing functions with `__attribute__` or varargs so some `extern` declarations are left behind to be dealt with in a future patch. This was the Coccinelle patch used: @@ type T; identifier f; @@ - extern T f(...); and it was run with: $ git ls-files \*.{c,h} | grep -v ^compat/ | xargs spatch --sp-file contrib/coccinelle/noextern.cocci --in-place Files under `compat/` are intentionally excluded as some are directly copied from external sources and we should avoid churning them as much as possible. Signed-off-by: Denton Liu Signed-off-by: Junio C Hamano --- upload-pack.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'upload-pack.h') diff --git a/upload-pack.h b/upload-pack.h index cab2178796..bc2ceb211c 100644 --- a/upload-pack.h +++ b/upload-pack.h @@ -13,11 +13,11 @@ void upload_pack(struct upload_pack_options *options); struct repository; struct argv_array; struct packet_reader; -extern int upload_pack_v2(struct repository *r, struct argv_array *keys, +int upload_pack_v2(struct repository *r, struct argv_array *keys, struct packet_reader *request); struct strbuf; -extern int upload_pack_advertise(struct repository *r, +int upload_pack_advertise(struct repository *r, struct strbuf *value); #endif /* UPLOAD_PACK_H */ -- cgit v1.2.3 From ad6dad0996f9226b2c3a5a3c725bf2952e52d7e7 Mon Sep 17 00:00:00 2001 From: Denton Liu Date: Mon, 29 Apr 2019 04:28:23 -0400 Subject: *.[ch]: manually align parameter lists In previous patches, extern was mechanically removed from function declarations without care to formatting, causing parameter lists to be misaligned. Manually format changed sections such that the parameter lists should be realigned. Viewing this patch with 'git diff -w' should produce no output. Signed-off-by: Denton Liu Signed-off-by: Junio C Hamano --- upload-pack.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'upload-pack.h') diff --git a/upload-pack.h b/upload-pack.h index bc2ceb211c..4bafe16a22 100644 --- a/upload-pack.h +++ b/upload-pack.h @@ -14,10 +14,10 @@ struct repository; struct argv_array; struct packet_reader; int upload_pack_v2(struct repository *r, struct argv_array *keys, - struct packet_reader *request); + struct packet_reader *request); struct strbuf; int upload_pack_advertise(struct repository *r, - struct strbuf *value); + struct strbuf *value); #endif /* UPLOAD_PACK_H */ -- cgit v1.2.3