From 7edc02f4deedb3a11abeb328dc2596b2886c2f47 Mon Sep 17 00:00:00 2001 From: Erik Faye-Lund Date: Fri, 17 Jan 2014 15:17:09 +0100 Subject: prefer xwrite instead of write Our xwrite wrapper already deals with a few potential hazards, and are as such more robust. Prefer it instead of write to get the robustness benefits everywhere. Signed-off-by: Erik Faye-Lund Reviewed-and-improved-by: Jonathan Nieder Signed-off-by: Junio C Hamano --- transport-helper.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'transport-helper.c') diff --git a/transport-helper.c b/transport-helper.c index 673b7c214f..ea34b39a81 100644 --- a/transport-helper.c +++ b/transport-helper.c @@ -1129,9 +1129,8 @@ static int udt_do_write(struct unidirectional_transfer *t) return 0; /* Nothing to write. */ transfer_debug("%s is writable", t->dest_name); - bytes = write(t->dest, t->buf, t->bufuse); - if (bytes < 0 && errno != EWOULDBLOCK && errno != EAGAIN && - errno != EINTR) { + bytes = xwrite(t->dest, t->buf, t->bufuse); + if (bytes < 0 && errno != EWOULDBLOCK) { error("write(%s) failed: %s", t->dest_name, strerror(errno)); return -1; } else if (bytes > 0) { -- cgit v1.2.3