From 953aa54e1a6a7571d48eddea3ee68745bf94e69d Mon Sep 17 00:00:00 2001 From: Jeff King Date: Sat, 1 May 2021 10:03:37 -0400 Subject: pack-objects: clamp negative window size to 0 A negative window size makes no sense, and the code in find_deltas() is not prepared to handle it. If you pass "-1", for example, we end up generate a 0-length array of "struct unpacked", but our loop assumes it has at least one entry in it (and we end up reading garbage memory). We could complain to the user about this, but it's more forgiving to just clamp it to 0, which means "do not find any deltas at all". The 0-case is already tested earlier in the script, so we'll make sure this does the same thing. Reported-by: Yiyuan guo Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- t/t5300-pack-object.sh | 5 +++++ 1 file changed, 5 insertions(+) (limited to 't') diff --git a/t/t5300-pack-object.sh b/t/t5300-pack-object.sh index 887e2d8d88..5c5e53f0be 100755 --- a/t/t5300-pack-object.sh +++ b/t/t5300-pack-object.sh @@ -613,4 +613,9 @@ test_expect_success '--stdin-packs with broken links' ' ) ' +test_expect_success 'negative window clamps to 0' ' + git pack-objects --progress --window=-1 neg-window stderr && + check_deltas stderr = 0 +' + test_done -- cgit v1.2.3