From c8f9d13dc6ddcb6c9e22584324c18b7d74e772ea Mon Sep 17 00:00:00 2001 From: Matthieu Moy Date: Mon, 8 Jan 2018 11:34:33 +0100 Subject: perl/Git: remove now useless email-address parsing code MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We now use Mail::Address unconditionaly, hence parse_mailboxes is now dead code. Remove it and its tests. Signed-off-by: Matthieu Moy Reviewed-by: Alex Bennée Signed-off-by: Junio C Hamano --- t/t9000/test.pl | 67 --------------------------------------------------------- 1 file changed, 67 deletions(-) delete mode 100755 t/t9000/test.pl (limited to 't/t9000') diff --git a/t/t9000/test.pl b/t/t9000/test.pl deleted file mode 100755 index dfeaa9c655..0000000000 --- a/t/t9000/test.pl +++ /dev/null @@ -1,67 +0,0 @@ -#!/usr/bin/perl -use lib (split(/:/, $ENV{GITPERLLIB})); - -use 5.008; -use warnings; -use strict; - -use Test::More qw(no_plan); -use Mail::Address; - -BEGIN { use_ok('Git') } - -my @success_list = (q[Jane], - q[jdoe@example.com], - q[], - q[Jane ], - q[Jane Doe ], - q["Jane" ], - q["Doe, Jane" ], - q["Jane@:;\>.,()], - q[Jane!#$%&'*+-/=?^_{|}~Doe' ], - q[""], - q["Jane jdoe@example.com"], - q[Jane Doe ], - q[Jane Doe < jdoe@example.com >], - q[Jane @ Doe @ Jane @ Doe], - q["Jane, 'Doe'" ], - q['Doe, "Jane' ], - q["Jane" "Do"e ], - q["Jane' Doe" ], - q["Jane Doe " ], - q["Jane\" Doe" ], - q[Doe, jane ], - q["Jane Doe ], - q['Jane 'Doe' ], - q[Jane@:;\.,()<>Doe ], - q[Jane Doe], - q[ Jane Doe]); - -my @known_failure_list = (q[Jane\ Doe ], - q["Doe, Ja"ne ], - q["Doe, Katarina" Jane ], - q[Jane jdoe@example.com], - q["Jane "Kat"a" ri"na" ",Doe" ], - q[Jane Doe], - q[Jane "Doe "], - q[\"Jane Doe ], - q[Jane\"\" Doe ], - q['Jane "Katarina\" \' Doe' ]); - -foreach my $str (@success_list) { - my @expected = map { $_->format } Mail::Address->parse("$str"); - my @actual = Git::parse_mailboxes("$str"); - is_deeply(\@expected, \@actual, qq[same output : $str]); -} - -TODO: { - local $TODO = "known breakage"; - foreach my $str (@known_failure_list) { - my @expected = map { $_->format } Mail::Address->parse("$str"); - my @actual = Git::parse_mailboxes("$str"); - is_deeply(\@expected, \@actual, qq[same output : $str]); - } -} - -my $is_passing = eval { Test::More->is_passing }; -exit($is_passing ? 0 : 1) unless $@ =~ /Can't locate object method/; -- cgit v1.2.3