From d9e6d0942bb9f9fe9e4cca9670181e5b59074bcb Mon Sep 17 00:00:00 2001 From: Matthew DeVore Date: Fri, 12 Oct 2018 13:01:41 -0700 Subject: filter-trees: code clean-up of tests A few trivial updates to test to match the current best practices. - avoid "grep -q" that strips potentially useful output from tests running under "-v". - use test_write_lines to prepare multi-line expected output file. - reserve use of test_must_fail to "git" commands. Signed-off-by: Matthew DeVore Signed-off-by: Junio C Hamano --- t/t5616-partial-clone.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 't/t5616-partial-clone.sh') diff --git a/t/t5616-partial-clone.sh b/t/t5616-partial-clone.sh index 53fbf7db88..392caa08fd 100755 --- a/t/t5616-partial-clone.sh +++ b/t/t5616-partial-clone.sh @@ -192,7 +192,7 @@ test_expect_success 'use fsck before and after manually fetching a missing subtr xargs -n1 git -C dst cat-file -t >fetched_types && sort -u fetched_types >unique_types.observed && - printf "blob\ncommit\ntree\n" >unique_types.expected && + test_write_lines blob commit tree >unique_types.expected && test_cmp unique_types.expected unique_types.observed ' -- cgit v1.2.3