From 650d30d8a120c8982309ccb9ef40432b4ea2eb74 Mon Sep 17 00:00:00 2001 From: Andreas Ericsson Date: Mon, 29 Jun 2009 11:55:51 +0200 Subject: mailinfo: Remove only one set of square brackets git-format-patch prepends patches with a [PATCH x/n] prefix, but mailinfo used to remove any number of square-bracket pairs and the content between them. This prevents one from using a commit subject like this: [ and ] must be allowed as input Removing the square bracket pair from this rather clumsily constructed subject line loses important information, so we must take care not to. This patch causes the subject stripping to stop after it has encountered one pair of square brackets. One possible downside of this patch is that the patch-handling programs will now fail at removing author-added square-brackets to be removed, such as [RFC][PATCH x/n] However, since format-patch only adds one set of square brackets, this behaviour is quite easily undesrstood and defended while the previous behaviour is not. Signed-off-by: Andreas Ericsson Signed-off-by: Junio C Hamano --- t/t5100/info0012 | 2 +- t/t5100/sample.mbox | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 't/t5100') diff --git a/t/t5100/info0012 b/t/t5100/info0012 index ac1216ff75..9cd1415d25 100644 --- a/t/t5100/info0012 +++ b/t/t5100/info0012 @@ -1,5 +1,5 @@ Author: Dmitriy Blinov Email: bda@mnsspb.ru -Subject: Изменён список пакетов необходимых для сборки +Subject: [Navy-patches] Изменён список пакетов необходимых для сборки Date: Wed, 12 Nov 2008 17:54:41 +0300 diff --git a/t/t5100/sample.mbox b/t/t5100/sample.mbox index c5ad206b40..ba4d0c9baf 100644 --- a/t/t5100/sample.mbox +++ b/t/t5100/sample.mbox @@ -514,7 +514,7 @@ MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit -Subject: [Navy-patches] [PATCH] +Subject: [PATCH] [Navy-patches] =?utf-8?b?0JjQt9C80LXQvdGR0L0g0YHQv9C40YHQvtC6INC/0LA=?= =?utf-8?b?0LrQtdGC0L7QsiDQvdC10L7QsdGF0L7QtNC40LzRi9GFINC00LvRjyA=?= =?utf-8?b?0YHQsdC+0YDQutC4?= -- cgit v1.2.3