From 4ef8d1dd03d3b8adf81b4b81b2231128e3591f36 Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Wed, 6 Nov 2013 10:00:57 -0800 Subject: sha1_loose_object_info(): do not return success on missing object Since 052fe5ea (sha1_loose_object_info: make type lookup optional, 2013-07-12), sha1_loose_object_info() returns happily without checking if the object in question exists, which is not what the the caller sha1_object_info_extended() expects; the caller does not even bother checking the existence of the object itself. Noticed-by: Sven Brauch Helped-by: Jeff King Signed-off-by: Junio C Hamano --- t/t1006-cat-file.sh | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 't/t1006-cat-file.sh') diff --git a/t/t1006-cat-file.sh b/t/t1006-cat-file.sh index 4e911fb43d..558f0f5292 100755 --- a/t/t1006-cat-file.sh +++ b/t/t1006-cat-file.sh @@ -179,6 +179,12 @@ test_expect_success "--batch-check for an emtpy line" ' test " missing" = "$(echo | git cat-file --batch-check)" ' +test_expect_success 'empty --batch-check notices missing object' ' + echo "$_z40 missing" >expect && + echo "$_z40" | git cat-file --batch-check="" >actual && + test_cmp expect actual +' + batch_input="$hello_sha1 $commit_sha1 $tag_sha1 -- cgit v1.2.3