From 554544276a604c144df45efcb060c80aa322088c Mon Sep 17 00:00:00 2001 From: Denton Liu Date: Mon, 29 Apr 2019 04:28:14 -0400 Subject: *.[ch]: remove extern from function declarations using spatch There has been a push to remove extern from function declarations. Remove some instances of "extern" for function declarations which are caught by Coccinelle. Note that Coccinelle has some difficulty with processing functions with `__attribute__` or varargs so some `extern` declarations are left behind to be dealt with in a future patch. This was the Coccinelle patch used: @@ type T; identifier f; @@ - extern T f(...); and it was run with: $ git ls-files \*.{c,h} | grep -v ^compat/ | xargs spatch --sp-file contrib/coccinelle/noextern.cocci --in-place Files under `compat/` are intentionally excluded as some are directly copied from external sources and we should avoid churning them as much as possible. Signed-off-by: Denton Liu Signed-off-by: Junio C Hamano --- serve.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'serve.h') diff --git a/serve.h b/serve.h index fe65ba9f46..48b6f5e479 100644 --- a/serve.h +++ b/serve.h @@ -2,7 +2,7 @@ #define SERVE_H struct argv_array; -extern int has_capability(const struct argv_array *keys, const char *capability, +int has_capability(const struct argv_array *keys, const char *capability, const char **value); struct serve_options { @@ -10,6 +10,6 @@ struct serve_options { unsigned stateless_rpc; }; #define SERVE_OPTIONS_INIT { 0 } -extern void serve(struct serve_options *options); +void serve(struct serve_options *options); #endif /* SERVE_H */ -- cgit v1.2.3 From ad6dad0996f9226b2c3a5a3c725bf2952e52d7e7 Mon Sep 17 00:00:00 2001 From: Denton Liu Date: Mon, 29 Apr 2019 04:28:23 -0400 Subject: *.[ch]: manually align parameter lists In previous patches, extern was mechanically removed from function declarations without care to formatting, causing parameter lists to be misaligned. Manually format changed sections such that the parameter lists should be realigned. Viewing this patch with 'git diff -w' should produce no output. Signed-off-by: Denton Liu Signed-off-by: Junio C Hamano --- serve.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'serve.h') diff --git a/serve.h b/serve.h index 48b6f5e479..42ddca7f8b 100644 --- a/serve.h +++ b/serve.h @@ -3,7 +3,7 @@ struct argv_array; int has_capability(const struct argv_array *keys, const char *capability, - const char **value); + const char **value); struct serve_options { unsigned advertise_capabilities; -- cgit v1.2.3