From 39fa2a983d55b37759b99e67f9f1892879efb775 Mon Sep 17 00:00:00 2001 From: "Shawn O. Pearce" Date: Mon, 11 Jun 2007 23:52:43 -0400 Subject: git-gui: Save geometry before the window layout is damaged Because Tk does not assure us the order that it will process children in before it destroys the main toplevel we cannot safely save our geometry data during a "bind . " event binding. The geometry may have already changed as a result of a one or more children being removed from the layout. This was pointed out in gitk by Mark Levedahl, and patched over there by commit b6047c5a8166a71e01c6b63ebbb67c6894d95114. So we now also use "wm protocol . WM_DELETE_WINDOW" to detect when the window is closed by the user, and forward that close event to our main do_quit routine. Signed-off-by: Shawn O. Pearce --- git-gui.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'git-gui.sh') diff --git a/git-gui.sh b/git-gui.sh index 0aecf41e65..97de595f27 100755 --- a/git-gui.sh +++ b/git-gui.sh @@ -1622,7 +1622,7 @@ unset browser doc_path doc_url # -- Standard bindings # -bind . {if {{%W} eq {.}} do_quit} +wm protocol . WM_DELETE_WINDOW do_quit bind all <$M1B-Key-q> do_quit bind all <$M1B-Key-Q> do_quit bind all <$M1B-Key-w> {destroy [winfo toplevel %W]} -- cgit v1.2.3