From 1a66a489d09e7b8629fa7e4184c78703f4eed335 Mon Sep 17 00:00:00 2001 From: Christian Couder Date: Tue, 2 Dec 2008 14:53:47 +0100 Subject: bisect: fix "git bisect skip " and add tests cases The patch that allows "git bisect skip" to be passed a range of commits using the ".." notation is flawed because it introduces a regression when it was passed a simple rev or commit. "git bisect skip " doesn't work any more, because is quoted but not properly unquoted. This patch fixes that and add tests cases to better check when it is passed commits and range of commits. While at it, this patch also properly quotes the non range arguments using the "sq" function. Signed-off-by: Christian Couder --- git-bisect.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'git-bisect.sh') diff --git a/git-bisect.sh b/git-bisect.sh index 6706bc1e7c..ddbdba8af1 100755 --- a/git-bisect.sh +++ b/git-bisect.sh @@ -199,11 +199,11 @@ bisect_skip() { *..*) revs=$(git rev-list "$arg") || die "Bad rev input: $arg" ;; *) - revs="'$arg'" ;; + revs=$(sq "$arg") ;; esac all="$all $revs" done - bisect_state 'skip' $all + eval bisect_state 'skip' $all } bisect_state() { -- cgit v1.2.3