From ad136370b2a26fd55f446722ff7bf5b383e8eca0 Mon Sep 17 00:00:00 2001 From: Antonio Ospite Date: Tue, 26 Jun 2018 12:47:05 +0200 Subject: config: move config_from_gitmodules to submodule-config.c The .gitmodules file is not meant as a place to store arbitrary configuration to distribute with the repository. Move config_from_gitmodules() out of config.c and into submodule-config.c to make it even clearer that it is not a mechanism to retrieve arbitrary configuration from the .gitmodules file. Signed-off-by: Antonio Ospite Acked-by: Brandon Williams Signed-off-by: Junio C Hamano --- config.h | 10 ---------- 1 file changed, 10 deletions(-) (limited to 'config.h') diff --git a/config.h b/config.h index 626d4654bd..b95bb7649d 100644 --- a/config.h +++ b/config.h @@ -215,16 +215,6 @@ extern int repo_config_get_maybe_bool(struct repository *repo, extern int repo_config_get_pathname(struct repository *repo, const char *key, const char **dest); -/* - * Note: This function exists solely to maintain backward compatibility with - * 'fetch' and 'update_clone' storing configuration in '.gitmodules' and should - * NOT be used anywhere else. - * - * Runs the provided config function on the '.gitmodules' file found in the - * working directory. - */ -extern void config_from_gitmodules(config_fn_t fn, void *data); - extern int git_config_get_value(const char *key, const char **value); extern const struct string_list *git_config_get_value_multi(const char *key); extern void git_config_clear(void); -- cgit v1.2.3