From 32fde6575e4139710ea5259ee9b7c750b7c2dde0 Mon Sep 17 00:00:00 2001 From: Joachim Schmitz Date: Mon, 17 Sep 2012 23:23:17 +0200 Subject: poll() exits too early with EFAULT if 1st arg is NULL If poll() is used as a milli-second sleep, like in help.c, by passing a NULL in the 1st and a 0 in the 2nd arg, it exits with EFAULT. As per Paolo Bonzini, the original author, this is a bug and to be fixed Like in this commit, which is not to exit if the 2nd arg is 0. It got fixed In gnulib in the same manner the other day. Signed-off-by: Joachim Schmitz Signed-off-by: Junio C Hamano --- compat/poll/poll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'compat/poll') diff --git a/compat/poll/poll.c b/compat/poll/poll.c index 49541f19cd..e4b8319fb7 100644 --- a/compat/poll/poll.c +++ b/compat/poll/poll.c @@ -353,7 +353,7 @@ poll (struct pollfd *pfd, nfds_t nfd, int timeout) /* EFAULT is not necessary to implement, but let's do it in the simplest case. */ - if (!pfd) + if (!pfd && nfd) { errno = EFAULT; return -1; -- cgit v1.2.3