From eccb614924c9067eeceffa503e4da3683f1c8b6b Mon Sep 17 00:00:00 2001 From: Jeff King Date: Tue, 9 Jul 2013 20:19:12 -0400 Subject: use "sentinel" function attribute for variadic lists This attribute can help gcc notice when callers forget to add a NULL sentinel to the end of the function. This is our first use of the sentinel attribute, but we shouldn't need to #ifdef for other compilers, as __attribute__ is already a no-op on non-gcc-compatible compilers. Suggested-by: Bert Wesarg More-Spots-Found-By: Matt Kraai Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- builtin/revert.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'builtin') diff --git a/builtin/revert.c b/builtin/revert.c index 0401fdb02c..b8b51746de 100644 --- a/builtin/revert.c +++ b/builtin/revert.c @@ -54,6 +54,7 @@ static int option_parse_x(const struct option *opt, return 0; } +__attribute__((sentinel)) static void verify_opt_compatible(const char *me, const char *base_opt, ...) { const char *this_opt; @@ -70,6 +71,7 @@ static void verify_opt_compatible(const char *me, const char *base_opt, ...) die(_("%s: %s cannot be used with %s"), me, this_opt, base_opt); } +__attribute__((sentinel)) static void verify_opt_mutually_compatible(const char *me, ...) { const char *opt1, *opt2 = NULL; -- cgit v1.2.3