From 8d2008196b4e6100cf90e8392106e82f46cc1a51 Mon Sep 17 00:00:00 2001 From: Tao Qingyun Date: Tue, 16 Oct 2018 22:54:28 +0800 Subject: builtin/branch.c: remove useless branch_get branch_get sometimes returns current_branch, which can be NULL (e.g., if you're on a detached HEAD). Try: $ git branch HEAD fatal: no such branch 'HEAD' $ git branch '' fatal: no such branch '' However, it seems weird that we'd check those cases here (and provide such lousy messages). And indeed, dropping that and letting us eventually hit create_branch() gives a much better message: $ git branch HEAD fatal: 'HEAD' is not a valid branch name. $ git branch '' fatal: '' is not a valid branch name. Signed-off-by: Tao Qingyun Signed-off-by: Junio C Hamano --- builtin/branch.c | 5 ----- 1 file changed, 5 deletions(-) (limited to 'builtin') diff --git a/builtin/branch.c b/builtin/branch.c index bbd006aab4..daf054598b 100644 --- a/builtin/branch.c +++ b/builtin/branch.c @@ -828,11 +828,6 @@ int cmd_branch(int argc, const char **argv, const char *prefix) git_config_set_multivar(buf.buf, NULL, NULL, 1); strbuf_release(&buf); } else if (argc > 0 && argc <= 2) { - struct branch *branch = branch_get(argv[0]); - - if (!branch) - die(_("no such branch '%s'"), argv[0]); - if (filter.kind != FILTER_REFS_BRANCHES) die(_("-a and -r options to 'git branch' do not make sense with a branch name")); -- cgit v1.2.3