From 6db5967d4e6640c5a3ee3cde151c5fdde5ab508f Mon Sep 17 00:00:00 2001 From: Johannes Schindelin Date: Fri, 19 Aug 2016 10:39:38 +0200 Subject: Revert "display HTML in default browser using Windows' shell API" Since 4804aab (help (Windows): Display HTML in default browser using Windows' shell API, 2008-07-13), Git for Windows used to call `ShellExecute()` to launch the default Windows handler for `.html` files. The idea was to avoid going through a shell script, for performance reasons. However, this change ignores the `help.browser` config setting. Together with browsing help not being a performance-critical operation, let's just revert that patch. Signed-off-by: Johannes Schindelin Signed-off-by: Junio C Hamano --- builtin/help.c | 7 ------- 1 file changed, 7 deletions(-) (limited to 'builtin') diff --git a/builtin/help.c b/builtin/help.c index 3c55ce4563..0c91ff5bfc 100644 --- a/builtin/help.c +++ b/builtin/help.c @@ -379,17 +379,10 @@ static void get_html_page_path(struct strbuf *page_path, const char *page) free(to_free); } -/* - * If open_html is not defined in a platform-specific way (see for - * example compat/mingw.h), we use the script web--browse to display - * HTML. - */ -#ifndef open_html static void open_html(const char *path) { execl_git_cmd("web--browse", "-c", "help.browser", path, (char *)NULL); } -#endif static void show_html_page(const char *git_cmd) { -- cgit v1.2.3