From 8e2af8f0db329a8c0211a309fa9cb611b6dc2517 Mon Sep 17 00:00:00 2001 From: David Aguilar Date: Thu, 30 Sep 2021 18:37:55 -0700 Subject: difftool: remove an unnecessary call to strbuf_release() The `buf` strbuf is reused again later in the same function, so there is no benefit to calling strbuf_release(). The subsequent usage is already using strbuf_reset() to reset the buffer, so releasing it early is only going to lead to a wasteful reallocation. Remove the early call to strbuf_release(). The same strbuf is already cleaned up in the "finish:" section so nothing is leaked, either. Signed-off-by: David Aguilar Signed-off-by: Junio C Hamano --- builtin/difftool.c | 2 -- 1 file changed, 2 deletions(-) (limited to 'builtin/difftool.c') diff --git a/builtin/difftool.c b/builtin/difftool.c index be7ed2acaa..1a415a15a3 100644 --- a/builtin/difftool.c +++ b/builtin/difftool.c @@ -568,8 +568,6 @@ static int run_dir_diff(const char *extcmd, int symlinks, const char *prefix, write_standin_files(entry, &ldir, ldir_len, &rdir, rdir_len); } - strbuf_release(&buf); - strbuf_setlen(&ldir, ldir_len); helper_argv[1] = ldir.buf; strbuf_setlen(&rdir, rdir_len); -- cgit v1.2.3