From 3f784a4dcbe270a1f48b23177917a1832a777d1c Mon Sep 17 00:00:00 2001 From: Sebastian Schuberth Date: Thu, 2 Jan 2014 17:15:44 +0100 Subject: git.c: consistently use the term "builtin" instead of "internal command" Signed-off-by: Sebastian Schuberth Signed-off-by: Junio C Hamano --- Documentation/technical/api-builtin.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'Documentation') diff --git a/Documentation/technical/api-builtin.txt b/Documentation/technical/api-builtin.txt index f3c1357b7c..150a02a558 100644 --- a/Documentation/technical/api-builtin.txt +++ b/Documentation/technical/api-builtin.txt @@ -14,7 +14,7 @@ Git: . Add the external declaration for the function to `builtin.h`. -. Add the command to `commands[]` table in `handle_internal_command()`, +. Add the command to `commands[]` table in `handle_builtin()`, defined in `git.c`. The entry should look like: { "foo", cmd_foo, }, -- cgit v1.2.3 From c6127fa3e25551e969d775b0332d37dc84db1969 Mon Sep 17 00:00:00 2001 From: Sebastian Schuberth Date: Thu, 2 Jan 2014 17:17:11 +0100 Subject: builtin/help.c: speed up is_git_command() by checking for builtin commands first Since 2dce956 is_git_command() is a bit slow as it does file I/O in the call to list_commands_in_dir(). Avoid the file I/O by adding an early check for the builtin commands. Signed-off-by: Sebastian Schuberth Signed-off-by: Junio C Hamano --- Documentation/technical/api-builtin.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'Documentation') diff --git a/Documentation/technical/api-builtin.txt b/Documentation/technical/api-builtin.txt index 150a02a558..e3d6e7a79a 100644 --- a/Documentation/technical/api-builtin.txt +++ b/Documentation/technical/api-builtin.txt @@ -14,8 +14,8 @@ Git: . Add the external declaration for the function to `builtin.h`. -. Add the command to `commands[]` table in `handle_builtin()`, - defined in `git.c`. The entry should look like: +. Add the command to the `commands[]` table defined in `git.c`. + The entry should look like: { "foo", cmd_foo, }, + -- cgit v1.2.3