From ae40ebda9bf68b0be8deafd93b7982d443f2b1b2 Mon Sep 17 00:00:00 2001 From: Stefan Beller Date: Fri, 26 Jun 2015 12:40:19 -0700 Subject: revision.c: remove unneeded check for NULL The function is called only from one place, which makes sure to have `interesting_cache` not NULL. Additionally the variable is a dereferenced a few lines before unconditionally, which would have resulted in a segmentation fault before hitting this check. Signed-off-by: Stefan Beller Acked-by: Jeff King Signed-off-by: Junio C Hamano --- revision.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/revision.c b/revision.c index 06f31d6fb5..e04bd3dffe 100644 --- a/revision.c +++ b/revision.c @@ -350,8 +350,8 @@ static int everybody_uninteresting(struct commit_list *orig, list = list->next; if (commit->object.flags & UNINTERESTING) continue; - if (interesting_cache) - *interesting_cache = commit; + + *interesting_cache = commit; return 0; } return 1; -- cgit v1.2.3