From 61b2a1acaae22b0b4cd45218525d9890e03b377c Mon Sep 17 00:00:00 2001 From: "Randall S. Becker" Date: Fri, 29 Sep 2017 07:47:17 +0900 Subject: poll.c: always set revents, even if to zero Match what is done to pfd[i].revents when compute_revents() returns 0 to the upstream gnulib's commit d42461c3 ("poll: fixes for large fds", 2015-02-20). The revents field is set to 0, without incrementing the value rc to be returned from the function. The original code left the field to whatever random value the field was initialized to. This fixes occasional hangs in git-upload-pack on HPE NonStop. Signed-off-by: Randall S. Becker Reviewed-by: Paolo Bonzini Signed-off-by: Junio C Hamano --- compat/poll/poll.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/compat/poll/poll.c b/compat/poll/poll.c index b10adc780f..ae03b74a6f 100644 --- a/compat/poll/poll.c +++ b/compat/poll/poll.c @@ -438,6 +438,10 @@ poll (struct pollfd *pfd, nfds_t nfd, int timeout) pfd[i].revents = happened; rc++; } + else + { + pfd[i].revents = 0; + } } return rc; -- cgit v1.2.3