From 9f60f49b9222f9200e688a64cd80610305b03cc5 Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Mon, 22 Apr 2013 13:29:20 -0700 Subject: git add: --ignore-removal is a better named --no-all In the historical context of "git add --all ." that pays attention to "all kinds of changes" (implying "without ignoring removals"), the option to countermand it "--no-all" may have made sense, but because we will be making "--all" the default when a pathspec is given, it makes more sense to rename the option to a more explicit "--ignore-removal". The "--all" option naturally becomes its negation, "--no-ignore-removal". Signed-off-by: Junio C Hamano --- Documentation/git-add.txt | 10 ++++++---- builtin/add.c | 11 +++++++++++ 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/Documentation/git-add.txt b/Documentation/git-add.txt index 5c501a299e..48754cbc67 100644 --- a/Documentation/git-add.txt +++ b/Documentation/git-add.txt @@ -9,9 +9,9 @@ SYNOPSIS -------- [verse] 'git add' [-n] [-v] [--force | -f] [--interactive | -i] [--patch | -p] - [--edit | -e] [--[no-]all | [--update | -u]] [--intent-to-add | -N] - [--refresh] [--ignore-errors] [--ignore-missing] [--] - [...] + [--edit | -e] [--[no-]all | --[no-]ignore-removal | [--update | -u]] + [--intent-to-add | -N] [--refresh] [--ignore-errors] [--ignore-missing] + [--] [...] DESCRIPTION ----------- @@ -111,6 +111,7 @@ of Git, hence the form without should not be used. -A:: --all:: +--no-ignore-removal:: Update the index not only where the working tree has a file matching but also where the index already has an entry. This adds, modifies, and removes index entries to @@ -122,6 +123,7 @@ and its subdirectories. This default will change in a future version of Git, hence the form without should not be used. --no-all:: +--ignore-removal:: Update the index by adding new files that are unknown to the index and files modified in the working tree, but ignore files that have been removed from the working tree. This @@ -130,7 +132,7 @@ of Git, hence the form without should not be used. This option is primarily to help the current users of Git, whose "git add ..." ignores removed files. In future versions of Git, "git add ..." will be a synonym to "git add -A -..." and "git add --no-all ..." will behave like +..." and "git add --ignore-removal ..." will behave like today's "git add ...", ignoring removed files. -N:: diff --git a/builtin/add.c b/builtin/add.c index 54cd2d417d..aefbc45570 100644 --- a/builtin/add.c +++ b/builtin/add.c @@ -382,6 +382,13 @@ static int ignore_add_errors, intent_to_add, ignore_missing; static int addremove = ADDREMOVE_DEFAULT; static int addremove_explicit = -1; /* unspecified */ +static int ignore_removal_cb(const struct option *opt, const char *arg, int unset) +{ + /* if we are told to ignore, we are not adding removals */ + *(int *)opt->value = !unset ? 0 : 1; + return 0; +} + static struct option builtin_add_options[] = { OPT__DRY_RUN(&show_only, N_("dry run")), OPT__VERBOSE(&verbose, N_("be verbose")), @@ -393,6 +400,10 @@ static struct option builtin_add_options[] = { OPT_BOOL('u', "update", &take_worktree_changes, N_("update tracked files")), OPT_BOOL('N', "intent-to-add", &intent_to_add, N_("record only the fact that the path will be added later")), OPT_BOOL('A', "all", &addremove_explicit, N_("add changes from all tracked and untracked files")), + { OPTION_CALLBACK, 0, "ignore-removal", &addremove_explicit, + NULL /* takes no arguments */, + N_("ignore paths removed in the working tree (same as --no-all)"), + PARSE_OPT_NOARG, ignore_removal_cb }, OPT_BOOL( 0 , "refresh", &refresh_only, N_("don't add, only refresh the index")), OPT_BOOL( 0 , "ignore-errors", &ignore_add_errors, N_("just skip files which cannot be added because of errors")), OPT_BOOL( 0 , "ignore-missing", &ignore_missing, N_("check if - even missing - files are ignored in dry run")), -- cgit v1.2.3 From 4c7114308ea12de7b69a3b282881398212dec8dd Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Mon, 22 Apr 2013 13:36:51 -0700 Subject: git add: rephrase -A/--no-all warning Now we have a synonym --ignore-removal for --no-all, we can rephrase the Git 2.0 transition warning message in a more natural way. Signed-off-by: Junio C Hamano --- builtin/add.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/builtin/add.c b/builtin/add.c index aefbc45570..c55615be4c 100644 --- a/builtin/add.c +++ b/builtin/add.c @@ -97,13 +97,13 @@ static int fix_unmerged_status(struct diff_filepair *p, } static const char *add_would_remove_warning = N_( - "You ran 'git add' with neither '-A (--all)' or '--no-all', whose\n" -"behaviour will change in Git 2.0 with respect to paths you removed from\n" -"your working tree. Paths like '%s' that are\n" -"removed are ignored with this version of Git.\n" + "You ran 'git add' with neither '-A (--all)' or '--ignore-removal',\n" +"whose behaviour will change in Git 2.0 with respect to paths you removed.\n" +"Paths like '%s' that are\n" +"removed from your working tree are ignored with this version of Git.\n" "\n" -"* 'git add --no-all ', which is the current default, ignores\n" -" paths you removed from your working tree.\n" +"* 'git add --ignore-removal ', which is the current default,\n" +" ignores paths you removed from your working tree.\n" "\n" "* 'git add --all ' will let you also record the removals.\n" "\n" -- cgit v1.2.3