From 3731449591130b2f5ca7257c46721785a6340a18 Mon Sep 17 00:00:00 2001 From: Michele Ballabio Date: Wed, 24 Feb 2010 21:49:03 +0100 Subject: shortlog: warn the user when there is no input A simple "git shortlog" outside of a git repository stalls waiting for an input. Check if that's the case by testing with isatty() before read_from_stdin(), and warn the user like "git commit" does in a similar case. Signed-off-by: Michele Ballabio Signed-off-by: Junio C Hamano --- builtin-shortlog.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/builtin-shortlog.c b/builtin-shortlog.c index b3b055f68c..22668b4d3d 100644 --- a/builtin-shortlog.c +++ b/builtin-shortlog.c @@ -295,6 +295,8 @@ parse_done: if (!nongit && !rev.pending.nr && isatty(0)) add_head_to_pending(&rev); if (rev.pending.nr == 0) { + if (isatty(0)) + fprintf(stderr, "(reading log message from standard input)\n"); read_from_stdin(&log); } else -- cgit v1.2.3